Browser manager support #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quigamdev
force-pushed
the
browser-manager
branch
from
47da20c to
9984bb2
Compare
|
NOTE: Firefox does support this feature, but it doesn't work on GitHub Actions (reason unknown). |
exyi
approved these changes
Jun 22, 2024
| var elem = browser.Single("#span"); | ||
| elem.Single("///***-*///@@##@šš+š++++---><<>''", By.XPath); | ||
| }); | ||
| throw new System.Exception("SelectMethod_InvalidXPathSelector_ExpectedException was supposed to fail!!!"); |
There was a problem hiding this comment.
This does not really make sense to me 😅 , did you intend to use Assert.Throws?
There was a problem hiding this comment.
Assert.Throw<> checks for specific exception. The mistake is incorrect place of the throw new exc.... I have corrected it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Selenium.WebDriver is distributed with browser manager since version 4.11. Browser manager makes sure that driver and browser are compatible and therefore the tests are not failing due to incompatibility of underlaying testing platform. In addition, browser manager is able to download webdrivers and browsers binaries (CfT).