Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add RootLayout support #619

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add RootLayout support #619

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions packages/runtime/src/registry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import {
Frame as TNSFrame,
Page as TNSPage,
ViewBase as TNSViewBase
ViewBase as TNSViewBase,
} from '@nativescript/core'
import { NSVElement, NSVViewFlags } from './nodes'
import { actionBarNodeOps } from './components/ActionBar'
Expand Down Expand Up @@ -30,7 +30,7 @@ export interface NSVElementDescriptor {
}

export let defaultViewMeta: NSVViewMeta = {
viewFlags: NSVViewFlags.NONE
viewFlags: NSVViewFlags.NONE,
}

let elementMap: Record<string, NSVElementDescriptor> = {}
Expand Down Expand Up @@ -86,7 +86,7 @@ export function registerElement(

elementMap[normalizedName] = {
meta: mergedMeta,
resolver
resolver,
}
// console.log(`->registerElement(${elementName})`)
}
Expand All @@ -99,6 +99,11 @@ export function isKnownView(elementName: string) {
// prettier-ignore
if (!__TEST__) {
// layouts
registerElement(
'RootLayout',
() => require('@nativescript/core').RootLayout,
{ viewFlags: NSVViewFlags.LAYOUT_VIEW }
)
registerElement(
'AbsoluteLayout',
() => require('@nativescript/core').AbsoluteLayout,
Expand Down