replace deprecated API calls #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
groverlynn
force-pushed
the
replace_deprecated
branch
from
3b8ba82 to
121d869
Compare
|
The code style change is distracting. |
groverlynn
force-pushed
the
replace_deprecated
branch
from
121d869 to
1cfe4c2
Compare
groverlynn
changed the title
groverlynn
force-pushed
the
replace_deprecated
branch
from
1cfe4c2 to
00cce5c
Compare
lotem
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically follows Apple documentation of recommended replacement/favoured API calls
P.S. There are numerous memory leaking problem in SquirrelPanel.m all related to CGPath and CGMutablePath never get released. Better use NSBezierPath and convert to CGPath in the final step when necessary. But the code mix CGPath with CGMutablePath making it impossible for others to even begin to correct. I have no choice but to leave it here