Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

derive: fail if requested template block is missing #341

Merged
merged 1 commit into from
Feb 9, 2025

Conversation

Kijewski
Copy link
Collaborator

@Kijewski Kijewski commented Feb 8, 2025

Previously it was only tested if the block exists if there were any blocks. If there weren't any, then an empty result would be rendered.

Fixes #336.

@Kijewski Kijewski marked this pull request as draft February 8, 2025 21:47
@Kijewski Kijewski marked this pull request as ready for review February 8, 2025 21:58
Previously it was only tested if the block exists if there were any
blocks. If there weren't any, then an empty result would be rendered.
@GuillaumeGomez
Copy link
Contributor

Nice, thanks!

@GuillaumeGomez GuillaumeGomez merged commit a0c8c43 into rinja-rs:master Feb 9, 2025
37 checks passed
@Kijewski Kijewski deleted the pr-missing-block branch February 9, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

#[template(block = "something_that_is_missing")] does **not** fail to compile
2 participants