-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Credentials and PermissionedDomain tx Support #1118
Open
achowdhry-ripple
wants to merge
21
commits into
staging
Choose a base branch
from
credentials
base: staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
2af4952
fix: correct typo for website in english translation (#1101)
kennyzlei b0dc30d
basic structure of new transactions
achowdhry-ripple 4c03487
simple tables completed
achowdhry-ripple d62f271
fix pr comments
achowdhry-ripple 5bb90a3
domain tx and cred tests
achowdhry-ripple e6ce307
add permission domain set
achowdhry-ripple 9522b3b
simple pages
achowdhry-ripple cf0cba3
tabledetail + cleanups
achowdhry-ripple 7472ae5
tabledetails
achowdhry-ripple efbbce0
tabledetails for permissioneddomain
achowdhry-ripple e467ceb
add tx to translations
achowdhry-ripple 6394624
remove unnecessary conditionals
achowdhry-ripple 380bb42
cred accept tests
achowdhry-ripple 3f22bd9
cred create tests
achowdhry-ripple 3a91e81
cred delete tests
achowdhry-ripple f5ef32d
pdd and pds tx tests
achowdhry-ripple ef4c025
alias properties for clarity
achowdhry-ripple 11982d1
typo
achowdhry-ripple 91a0372
pull new version xrpl
achowdhry-ripple a88a448
lint
achowdhry-ripple 0c4d960
remove extra file
achowdhry-ripple File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
pdd and pds tx tests
- Loading branch information
commit f5ef32dec942228c6c0b663b229070cdabee633b
There are no files selected for viewing
Empty file.
18 changes: 18 additions & 0 deletions
18
...ponents/Transaction/PermissionedDomainDelete/test/PermissionedDomainDeleteSimple.test.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
import { createSimpleWrapperFactory, expectSimpleRowText } from '../../test' | ||
import { Simple } from '../Simple' | ||
import PermissionedDomainDelete from './mock_data/PermissionedDomainDelete.json' | ||
|
||
const createWrapper = createSimpleWrapperFactory(Simple) | ||
|
||
describe('PermissionedDomainDeleteSimple: Renders', () => { | ||
it('renders', () => { | ||
const wrapper = createWrapper(PermissionedDomainDelete) | ||
expectSimpleRowText( | ||
wrapper, | ||
'domain_id', | ||
'F075484241C8FD27C750F1DD93E0B5E0A42D9ADFE5E7B2313DD927E3DE0DBA6E', | ||
) | ||
|
||
wrapper.unmount() | ||
}) | ||
}) |
17 changes: 17 additions & 0 deletions
17
...ts/Transaction/PermissionedDomainDelete/test/PermissionedDomainDeleteTableDetail.test.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
import { createTableDetailWrapperFactory } from '../../test' | ||
import { TableDetail } from '../TableDetail' | ||
import PermissionedDomainDelete from './mock_data/PermissionedDomainDelete.json' | ||
|
||
const createWrapper = createTableDetailWrapperFactory(TableDetail) | ||
|
||
describe('CredentialDeleteTableDetail ', () => { | ||
it('renders CredentialDeleteTableDetail', () => { | ||
const wrapper = createWrapper(PermissionedDomainDelete) | ||
|
||
expect(wrapper.find('domain_id')).toEqual( | ||
'F075484241C8FD27C750F1DD93E0B5E0A42D9ADFE5E7B2313DD927E3DE0DBA6E', | ||
) | ||
|
||
wrapper.unmount() | ||
}) | ||
}) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 changes: 23 additions & 0 deletions
23
...ed/components/Transaction/PermissionedDomainSet/test/PermissionedDomainSetSimple.test.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
import { createSimpleWrapperFactory, expectSimpleRowText } from '../../test' | ||
import { Simple } from '../Simple' | ||
import PermissionedDomainSet from './mock_data/PermissionedDomainSet.json' | ||
|
||
const createWrapper = createSimpleWrapperFactory(Simple) | ||
|
||
describe('PermissionedDomainSetSimple: Renders', () => { | ||
it('renders', () => { | ||
const wrapper = createWrapper(PermissionedDomainSet) | ||
expectSimpleRowText( | ||
wrapper, | ||
'domain_id', | ||
'F075484241C8FD27C750F1DD93E0B5E0A42D9ADFE5E7B2313DD927E3DE0DBA6E', | ||
) | ||
expectSimpleRowText( | ||
wrapper, | ||
'accepted_credentials', | ||
'F075484241C8FD27C750F1DD93E0B5E0A42D9ADFE5E7B2313DD927E3DE0DBA6E', | ||
) | ||
|
||
wrapper.unmount() | ||
}) | ||
}) |
Empty file.
21 changes: 21 additions & 0 deletions
21
...mponents/Transaction/PermissionedDomainSet/test/PermissionedDomainSetTableDetail.test.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
import { createTableDetailWrapperFactory } from '../../test' | ||
import { TableDetail } from '../TableDetail' | ||
import PermissionedDomainSet from './mock_data/PermissionedDomainSet.json' | ||
|
||
const createWrapper = createTableDetailWrapperFactory(TableDetail) | ||
|
||
describe('CredentialSetTableDetail', () => { | ||
it('renders CredentialSetTableDetail', () => { | ||
const wrapper = createWrapper(PermissionedDomainSet) | ||
|
||
expect(wrapper.find('domain_id')).toEqual( | ||
'F075484241C8FD27C750F1DD93E0B5E0A42D9ADFE5E7B2313DD927E3DE0DBA6E', | ||
) | ||
|
||
expect(wrapper.find('accepted_credentials')).toEqual( | ||
'F075484241C8FD27C750F1DD93E0B5E0A42D9ADFE5E7B2313DD927E3DE0DBA6E', | ||
) | ||
|
||
wrapper.unmount() | ||
}) | ||
}) |
137 changes: 70 additions & 67 deletions
137
...ed/components/Transaction/PermissionedDomainSet/test/mock_data/PermissionedDomainSet.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,83 +1,86 @@ | ||
{ | ||
"close_time_iso ": "2025-01-21T01:51:40Z ", | ||
"ctid ": "C000005A0000F7E0 ", | ||
"hash ": "1008A97884DD03C3B4812C53D01B2482F55B9C2E1E1323DE468B862BA002A771 ", | ||
"ledger_hash ": "E60EC716557B89B709B037D2AE8252A909020E31CAE0C4659FB2739F47997979 ", | ||
"ledger_index ": 90, | ||
"meta ": { | ||
"AffectedNodes ": [ | ||
"close_time_iso": "2025-01-19T02:21:39Z", | ||
"ctid": "C00000400000F7E0", | ||
"hash": "561E23C018C9D6B9A1C03F1AD90E2DEB57DEF5ADA0C3886004F3B1423948A9A7", | ||
"ledger_hash": "D9408AA31B24A03E999C13FE93B0D43174FD1CC4BACE884B012E7FAB255BDEED", | ||
"ledger_index": 64, | ||
"meta": { | ||
"AffectedNodes": [ | ||
{ | ||
"ModifiedNode ": { | ||
"FinalFields ": { | ||
"Account ": "rhBPeJFG9pxvU22AxkzBpt6zzyk89xhdr3 ", | ||
"Balance ": "1999997599 ", | ||
"Flags ": 0, | ||
"OwnerCount ": 3, | ||
"Sequence ": 77 | ||
}, | ||
"LedgerEntryType ": "AccountRoot ", | ||
"LedgerIndex ": "5A8ABEB4FA540056A51E0D25177DB7E672E6D7E947DF5D347B9E1489D106F873 ", | ||
"PreviousFields ": { | ||
"Balance ": "1999997799 ", | ||
"OwnerCount ": 4, | ||
"Sequence ": 76 | ||
}, | ||
"PreviousTxnID ": "676E4F1DF5DC4F9C2223DDE9999EF5A8392B310C49B84C7AB04BA10A6CDABFE4 ", | ||
"PreviousTxnLgrSeq ": 89 | ||
"CreatedNode": { | ||
"LedgerEntryType": "PermissionedDomain", | ||
"LedgerIndex": "1FF57AD569BC5258A4D3C5AAB77DDEBB68E286F72D8EAB49DEE3DD35C2C5A4AF", | ||
"NewFields": { | ||
"AcceptedCredentials": [ | ||
{ | ||
"Credential": { | ||
"CredentialType": "4964656E74697479446F63756D656E74", | ||
"Issuer": "rUVQzukKnGSw4qNjEvBxLxquaLaMwzVBab" | ||
} | ||
} | ||
], | ||
"Owner": "rUVQzukKnGSw4qNjEvBxLxquaLaMwzVBab", | ||
"Sequence": 50 | ||
} | ||
} | ||
}, | ||
{ | ||
"ModifiedNode ": { | ||
"FinalFields ": { | ||
"Flags ": 0, | ||
"Owner ": "rhBPeJFG9pxvU22AxkzBpt6zzyk89xhdr3 ", | ||
"RootIndex ": "D9B8A922B4C857D4BA2CED2870A54D0DF9A45F7D9F7A145B627E291CCBD73FEE " | ||
"ModifiedNode": { | ||
"FinalFields": { | ||
"Flags": 0, | ||
"Owner": "rUVQzukKnGSw4qNjEvBxLxquaLaMwzVBab", | ||
"RootIndex": "3ECFCBD5393D4EBA88476B159B542BD7D2159D72BF35488ED294E90931567D93" | ||
}, | ||
"LedgerEntryType ": "DirectoryNode ", | ||
"LedgerIndex ": "D9B8A922B4C857D4BA2CED2870A54D0DF9A45F7D9F7A145B627E291CCBD73FEE ", | ||
"PreviousTxnID ": "676E4F1DF5DC4F9C2223DDE9999EF5A8392B310C49B84C7AB04BA10A6CDABFE4 ", | ||
"PreviousTxnLgrSeq ": 89 | ||
"LedgerEntryType": "DirectoryNode", | ||
"LedgerIndex": "3ECFCBD5393D4EBA88476B159B542BD7D2159D72BF35488ED294E90931567D93", | ||
"PreviousTxnID": "E3A10DD121B54CB7D8922A77D26C9D766FD8A07850287F278F9313057D664DD4", | ||
"PreviousTxnLgrSeq": 63 | ||
} | ||
}, | ||
{ | ||
"DeletedNode ": { | ||
"FinalFields ": { | ||
"AcceptedCredentials ": [ | ||
{ | ||
"Credential ": { | ||
"CredentialType ": "4964656E74697479446F63756D656E74 ", | ||
"Issuer ": "rhBPeJFG9pxvU22AxkzBpt6zzyk89xhdr3 " | ||
} | ||
} | ||
], | ||
"Flags ": 0, | ||
"Owner ": "rhBPeJFG9pxvU22AxkzBpt6zzyk89xhdr3 ", | ||
"OwnerNode ": "0 ", | ||
"PreviousTxnID ": "676E4F1DF5DC4F9C2223DDE9999EF5A8392B310C49B84C7AB04BA10A6CDABFE4 ", | ||
"PreviousTxnLgrSeq ": 89, | ||
"Sequence ": 75 | ||
"ModifiedNode": { | ||
"FinalFields": { | ||
"Account": "rUVQzukKnGSw4qNjEvBxLxquaLaMwzVBab", | ||
"Balance": "1999997799", | ||
"Flags": 0, | ||
"OwnerCount": 4, | ||
"Sequence": 51 | ||
}, | ||
"LedgerEntryType ": "PermissionedDomain ", | ||
"LedgerIndex ": "F075484241C8FD27C750F1DD93E0B5E0A42D9ADFE5E7B2313DD927E3DE0DBA6E " | ||
"LedgerEntryType": "AccountRoot", | ||
"LedgerIndex": "DBACFFF9DBF52B26633B4CED74BD43E8AEF09C20F46C80D83C3A3230BD4E3985", | ||
"PreviousFields": { | ||
"Balance": "1999997999", | ||
"OwnerCount": 3, | ||
"Sequence": 50 | ||
}, | ||
"PreviousTxnID": "E3A10DD121B54CB7D8922A77D26C9D766FD8A07850287F278F9313057D664DD4", | ||
"PreviousTxnLgrSeq": 63 | ||
} | ||
} | ||
], | ||
"TransactionIndex ": 0, | ||
"TransactionResult ": "tesSUCCESS " | ||
"TransactionIndex": 0, | ||
"TransactionResult": "tesSUCCESS" | ||
}, | ||
"tx_json ": { | ||
"Account ": "rhBPeJFG9pxvU22AxkzBpt6zzyk89xhdr3 ", | ||
"DomainID ": "F075484241C8FD27C750F1DD93E0B5E0A42D9ADFE5E7B2313DD927E3DE0DBA6E ", | ||
"Fee ": "200 ", | ||
"Flags ": 0, | ||
"LastLedgerSequence ": 109, | ||
"NetworkID ": 63456, | ||
"Sequence ": 76, | ||
"SigningPubKey ": "ED0FD90553E43698CA5878F9AE1063AF1178728324356BFF116D3331B243F11FDD ", | ||
"TransactionType ": "PermissionedDomainDelete ", | ||
"TxnSignature ": "9C248D71E6221DBBE2F65DB2D3B7B0B0DF8FA11057A60719CCBE6A257D6255068E39D82C740ED7B05B3C99A4A591DA59847C0222A6B5F8DC90C480D249F30E01 ", | ||
"date ": 790739500, | ||
"ledger_index ": 90 | ||
"tx_json": { | ||
"AcceptedCredentials": [ | ||
{ | ||
"Credential": { | ||
"CredentialType": "4964656E74697479446F63756D656E74", | ||
"Issuer": "rUVQzukKnGSw4qNjEvBxLxquaLaMwzVBab" | ||
} | ||
} | ||
], | ||
"Account": "rUVQzukKnGSw4qNjEvBxLxquaLaMwzVBab", | ||
"Fee": "200", | ||
"Flags": 0, | ||
"LastLedgerSequence": 83, | ||
"NetworkID": 63456, | ||
"Sequence": 50, | ||
"SigningPubKey": "ED7EE9DDAFF54720AD642944B666CC359091F170BA49C084C3E59803ACDBB17647", | ||
"TransactionType": "PermissionedDomainSet", | ||
"TxnSignature": "B505D12FEDCBAEE792FE5317253E633C094F5D7D8B6D3C9A54B4EAF1F56B2D7F537356D1292A2BAFAE163343BD659F05BF8C916EBA0B10B54D78F20B33B93205", | ||
"date": 790568499, | ||
"ledger_index": 64 | ||
}, | ||
"validated ": true | ||
"validated": true | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems incorrect