Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add currency asset for ETH #209

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lgcarrier
Copy link

I'm not sure about the specs (e.g.: width and height) needed for the currency assets.

@intelliot
Copy link
Collaborator

Hi @lgcarrier - thanks for opening this PR. Are you running an instance of the Data API? If so, what do you use it for?

This project has not been actively developed for some years. It is now being deprecated.

@lgcarrier
Copy link
Author

Hi @intelliot, I'm not running an instance of the Data API. I'm simply using the API (see https://xrpl.org/data-api.html) to retrieve top currencies and currency images using documented APIs.

POC: https://lgcarrier.github.io/xrp-issuing-gateways/ (see the missing currency icon in the "Top Currencies" section)

Thanks,
LG

@Try-Parser
Copy link

Hi @lgcarrier - thanks for opening this PR. Are you running an instance of the Data API? If so, what do you use it for?

This project has not been actively developed for some years. It is now being deprecated.

hi @intelliot currently looking for this api which is currently not existing in the xrpl.org do they plan on adding this on their side ? or do we have alternative for this in xrpl.org ?

Get Exchanges - GET /v2/exchanges/{base}/{counter}
Get Exchange Rates - GET /v2/exchange_rates/{base}/{counter}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants