Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add version subcommand #50

Merged
merged 4 commits into from
Nov 19, 2024
Merged

Conversation

InnocentZero
Copy link
Collaborator

@InnocentZero InnocentZero commented Nov 15, 2024

Closes #46

Signed-off-by: innocentzero <[email protected]>
@InnocentZero
Copy link
Collaborator Author

One problem with rustup is that it prints two lines to stderr and hence `run_command_for_stdout_ doesn't capture those lines, causing them to appear at first out of order with everything else.

@ripytide ripytide marked this pull request as ready for review November 16, 2024 23:43
@ripytide
Copy link
Owner

I've re-worked some stuff to remove a dependency and added another dependency to remove a macro call.

Copy link
Owner

@ripytide ripytide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve now, but I'm biased since I've just added a commit so it might be best if you review it now too.

@InnocentZero
Copy link
Collaborator Author

This looks good. I forgot strum enum-iterator existed.

@InnocentZero InnocentZero merged commit 6c1b844 into ripytide:main Nov 19, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Command to check which backends are found on the system.
2 participants