Skip to content

Fix modinv Montgomery bug #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix modinv Montgomery bug #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/no_asm.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1142,11 +1142,15 @@ static limb_t smul_2n(limb_t ret[], const limb_t u[], limb_t f,
#if defined(__ZKVM__)
inline void ct_inverse_mod_256(vec512 ret, const vec256 inp,
const vec256 mod, const vec256 modx) { //untested
r0bigint_modinv_256(inp, mod, ret);
vec256 tmp;
r0bigint_modinv_256(inp, mod, tmp);
r0bigint_modmul_256(tmp, BLS12_381_rRR, mod, ret);
}
inline void ct_inverse_mod_384(vec768 ret, const vec384 inp,
const vec384 mod, const vec384 modx) {
r0bigint_modinv_384(inp, mod, ret);
vec384 tmp;
r0bigint_modinv_384(inp, mod, tmp);
r0bigint_modmul_384(tmp, BLS12_381_RR, mod, ret);
}
#else
static void ct_inverse_mod_n(limb_t ret[], const limb_t inp[],
Expand Down