Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workshop -> nit picks and questions #125

Closed
wants to merge 1 commit into from
Closed

Workshop -> nit picks and questions #125

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ Your new project consists of:
- Builds for zkVM program, the publisher app, and any other Rust code.

```sh
cargo build
cargo build --release
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the only reason we must run this first is because forge is looking to get an Elf.sol that this builds?

Or should we be optimizing here for the forge b next?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed cargo build generates the ImageID.sol and Elf.sol files, which is the primary reason it needs to run first. I don't know of any way to achieve this just by running forge build or forge test.

I don't see any reason to run with --release, since the performance is not an issue in client-server mode.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also --release takes a lot longer to build, so if you're in client/server, it might not be worth it.

```

- Build your Solidity smart contracts
Expand Down
Loading