bump to 0.20 #73
Merged
bump to 0.20 #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mothran
approved these changes
Jan 25, 2024
.github/workflows/test.yml
Outdated
| @@ -42,7 +44,7 @@ jobs: | |||
| version: "1.4" | |||
|
|
|||
| - name: Cargo binstall cargo-risczero | |||
| run: cargo binstall -y --force cargo-risczero@0.19.1 | |||
| run: cargo binstall -y --force cargo-risczero@0.20.0-rc.2 | |||
There was a problem hiding this comment.
Currently bonsai staging is at rc3, so might be worth bumping up to that for testing.
Cargo.toml
Outdated
| bonsai-ethereum-relay = { version = "0.5.1" } | ||
| risc0-build = { version = "0.20.0-rc.2" } | ||
| risc0-zkvm = { version = "0.20.0-rc.2", default-features = false } | ||
| bonsai-sdk = { version = "0.6.0-rc.1" } |
relay/src/main.rs
Outdated
| @@ -27,7 +27,14 @@ use methods::GUEST_LIST; | |||
| use risc0_zkvm::sha::Digest; | |||
|
|
|||
| /// Index 0 private key generated by default in Anvil. | |||
| const ANVIL_DEFAULT_KEY: &str = "ac0974bec39a17e36ba4a6b4d238ff944bacb478cbed5efcae784d7bf4f2ff80"; | |||
| const ANVIL_DEFAULT_KEY: &'static str = | |||
There was a problem hiding this comment.
This should be a clippy error but: you shouldn't need &'static for const &str's because its implied
relay/src/main.rs
Outdated
| } => { | ||
| let relayer = Relayer { | ||
| rest_api: true, | ||
| dev_mode, | ||
| dev_mode: dev_mode, |
There was a problem hiding this comment.
I think clippy would suggest keeping this just dev_mode, any reason to not use the alias assignment?
capossele
force-pushed
the
capossele/bump-0.20
branch
from
11b4447 to
8a58c2f
Compare
nategraf
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: