-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zfinx ACT #17
Comments
Per email from Prasanna on 4/11:
|
Having few challenges in implementing the sign prefix for Zfinx, the change has to be inline with the model that we use. Planning to run the test against spike to see the results if it is different than sail. |
keeping up the same work as before, continuing to progress on the test run to increase the coverage percentage achieved. |
Thanks, @ptprasanna! Any chance you could report coverage percentage as we progress? |
Completed with the tests and coverage run. Have sent the tests for peer review before raising the PR. |
Great new, @ptprasanna! Fingers crossed. |
@jjscheel - Please change the PR to be as below riscv-non-isa/riscv-arch-test#367 |
Updated. Thank you! |
All the Comments that were provided are incorporated, and awaiting PR approval and merge..! |
Decoded using rvopcodesdecoder and placed the report in the below link https://gitlab.com/ptprasanna/actreports/-/tree/main/RV64Zfinx?ref_type=heads |
Sounds like we are close! THANKS. |
@ptprasanna, I would like an update in the issue, by the next meeting on December 12, 2023, please. |
|
Zfinx and Zfh PR from CTG has been waiting for review. |
Zfinx and Zfh PR for ISAC has been merged. Zfinx and Zfh PR in arch-test suite has been merged. Only Zfinx and Zfh PR from CTG has been waiting for approval by Neel. |
Thanks, @anuani21. Understand. @allenjbaum, here is where the work is needed. |
Zfinx and Zfh PR from CTG still waiting for approval. |
@allenjbaum and @anuani21, I'm inclined to simply mark this as Blocked and leave it for the community to pick up. It's not fair to IITM to ask them to continue working/watching something that hasn't moved in almost 9 months. |
I will try to make merge riscv-ctg PR as soon as possible
…On Tue, 16 Apr, 2024, 6:27 pm Jeff Scheel, ***@***.***> wrote:
@allenjbaum <https://github.com/allenjbaum> and @anuani21
<https://github.com/anuani21>, I'm inclined to simply mark this as
Blocked and leave it for the community to pick up. It's not fair to IITM to
ask them to continue working/watching something that hasn't moved in almost
9 months.
—
Reply to this email directly, view it on GitHub
<#17 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3G6FF3FFA3ZLLQGYYWOSJTY5UN4TAVCNFSM6AAAAAAV6RUI6GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJZGAZTANZTGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Thanks, @anuani21. Please work with Arch Test SIG and @allenjbaum to see if it can be merged. If they still cannot find people to review it, I propose we simply leave it there until the community becomes active again. |
@anuani21, any new status here? |
All PR in riscv-ctg,riscv-isac and riscv-arch-test are merged for Zfh and Zfinx. |
@allenjbaum, can you kindly review the work here and signoff on its completion? A simple approval comment will suffice. |
@allenjbaum, given this comment Zfh ACT #18, I'm going to consider this closed because the PRs were for both Zfh and Zfinx. Please let me know if that is not correct. |
Technical Group
Unprivileged Spec IC
ratification-pkg
Zfinx
Technical Liaison
Tariq Kurd
Task Category
Arch Tests
Task Sub Category
Ratification Target
4Q2021
Statement of Work (SOW)
SOW: link
SOW Signoffs: (delete those not needed)
Waiver
Pull Request Details
The text was updated successfully, but these errors were encountered: