Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zfinx ACT #17

Closed
2 of 13 tasks
jjscheel opened this issue Mar 17, 2023 · 24 comments
Closed
2 of 13 tasks

Zfinx ACT #17

jjscheel opened this issue Mar 17, 2023 · 24 comments
Assignees

Comments

@jjscheel
Copy link
Contributor

jjscheel commented Mar 17, 2023

Technical Group

Unprivileged Spec IC

ratification-pkg

Zfinx

Technical Liaison

Tariq Kurd

Task Category

Arch Tests

Task Sub Category

  • gcc
  • binutils
  • gdb
  • intrinsics
  • Java
  • KVM
  • ld
  • llvm
  • Linux kernel
  • QEMU
  • Spike

Ratification Target

4Q2021

Statement of Work (SOW)

SOW: link

SOW Signoffs: (delete those not needed)

  • Task group liaison sign-off date: N/A (no longer active)
  • Development partner sign-off date: 9/3/2024 (Anusha)
  • ACT SIG sign-off date (if ACT work): 9/18/2024 (Allen)

Waiver

  • Freeze
  • Ratification

Pull Request Details

@jjscheel
Copy link
Contributor Author

Per email from Prasanna on 4/11:

Zfinix and Zfh : Scheduled a call tomorrow to discuss on the possible solution with respect to sign extension of Zfinix in RV64 (One of the comment provided) - In progress

@ptprasanna
Copy link

ptprasanna commented Apr 25, 2023

Having few challenges in implementing the sign prefix for Zfinx, the change has to be inline with the model that we use. Planning to run the test against spike to see the results if it is different than sail.

@ptprasanna
Copy link

keeping up the same work as before, continuing to progress on the test run to increase the coverage percentage achieved.

@jjscheel
Copy link
Contributor Author

jjscheel commented May 9, 2023

Thanks, @ptprasanna! Any chance you could report coverage percentage as we progress?

@ptprasanna
Copy link

Completed with the tests and coverage run. Have sent the tests for peer review before raising the PR.

@jjscheel
Copy link
Contributor Author

Great new, @ptprasanna! Fingers crossed.

@ptprasanna
Copy link

ptprasanna commented Jul 18, 2023

@jjscheel
Copy link
Contributor Author

Updated. Thank you!

@ptprasanna
Copy link

All the Comments that were provided are incorporated, and awaiting PR approval and merge..!

@anuani21
Copy link

Decoded using rvopcodesdecoder and placed the report in the below link

https://gitlab.com/ptprasanna/actreports/-/tree/main/RV64Zfinx?ref_type=heads

@jjscheel
Copy link
Contributor Author

Sounds like we are close! THANKS.

@jjscheel
Copy link
Contributor Author

@ptprasanna, I would like an update in the issue, by the next meeting on December 12, 2023, please.

@jjscheel
Copy link
Contributor Author

jjscheel commented Jan 9, 2024

Per @anuani21 in #20:

Zfinx and Zfh PR for ISAC has been merged.
riscv-software-src/riscv-isac#72

Zfinx and Zfh PR from CTG has been waiting for review.
riscv-software-src/riscv-ctg#67

@anuani21
Copy link

Zfinx and Zfh PR from CTG has been waiting for review.
riscv-software-src/riscv-ctg#67

@anuani21
Copy link

anuani21 commented Apr 2, 2024

@jjscheel,

Zfinx and Zfh PR for ISAC has been merged.
riscv-software-src/riscv-isac#72

Zfinx and Zfh PR in arch-test suite has been merged.
riscv-non-isa/riscv-arch-test#367

Only Zfinx and Zfh PR from CTG has been waiting for approval by Neel.
riscv-software-src/riscv-ctg#67

@jjscheel
Copy link
Contributor Author

jjscheel commented Apr 2, 2024

Thanks, @anuani21. Understand.

@allenjbaum, here is where the work is needed.

@anuani21
Copy link

@jjscheel,

Zfinx and Zfh PR from CTG still waiting for approval.
riscv-software-src/riscv-ctg#67

@jjscheel
Copy link
Contributor Author

@allenjbaum and @anuani21, I'm inclined to simply mark this as Blocked and leave it for the community to pick up. It's not fair to IITM to ask them to continue working/watching something that hasn't moved in almost 9 months.

@jjscheel jjscheel mentioned this issue Apr 16, 2024
13 tasks
@jjscheel jjscheel moved this from As-planned to Blocked in RISC-V DevPartner Work Apr 16, 2024
@anuani21
Copy link

anuani21 commented Apr 16, 2024 via email

@jjscheel
Copy link
Contributor Author

Thanks, @anuani21. Please work with Arch Test SIG and @allenjbaum to see if it can be merged. If they still cannot find people to review it, I propose we simply leave it there until the community becomes active again.

@jjscheel
Copy link
Contributor Author

@anuani21, any new status here?

@anuani21
Copy link

anuani21 commented Sep 3, 2024

@jjscheel,

All PR in riscv-ctg,riscv-isac and riscv-arch-test are merged for Zfh and Zfinx.

@jjscheel
Copy link
Contributor Author

@allenjbaum, can you kindly review the work here and signoff on its completion? A simple approval comment will suffice.

@jjscheel
Copy link
Contributor Author

@allenjbaum, given this comment Zfh ACT #18, I'm going to consider this closed because the PRs were for both Zfh and Zfinx. Please let me know if that is not correct.

@jjscheel jjscheel moved this from Blocked to Late in RISC-V DevPartner Work Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Late
Development

No branches or pull requests

4 participants