Upgrade CI commands to resolve warnings #1329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kito-cheng
approved these changes
Sep 12, 2023
|
ooop, it seems conflict with your another PR |
patrick-rivos
force-pushed
the
upgrade-actions
branch
from
938c26f
to
105c5ff
Compare
Yep - I'm pretty sure the failure was due to the disk getting filled from the LLVM build. I rebased it so it should be good now. |
cmuellner
approved these changes
Sep 29, 2023
There was a problem hiding this comment.
The major change is to resolve a deprecation which is documented here: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a large number of warnings in the CI. This PR resolves those warnings by upgrading/removing deprecated CI commands.
Resolved warnings:
https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/