Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Linux/uClibc-ng toolchain build in CI #1578

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

TommyMurphyTM1234
Copy link
Collaborator

See:

Notes:

  1. I don't think that I can test these changes locally so am creating the PR on the assumption that they will be sanity checked server side.
  2. While "ulibc" is used across riscv-gnu-toolchain to refer to this toolchain variant, it is actually uClibc-ng based and not based on the original uClibc.
  3. For this reason I have used "uclibc-ng" when naming the build tarball artifact but I don't know if the dash in this string will be in any way problematic or inconsistent with the existing naming convention?
  4. I may need to rebase this if/when other pending PRs that I have submitted today are merged.
  5. I am assuming that, like the Linux/musl toolchain variant. LLVM is also not an option for the uClibc-ng toolchain?
  6. As ever, I'm open to constructive feedback and comments. :-)

@TommyMurphyTM1234
Copy link
Collaborator Author

Second attempt at doing this:

@cmuellner
Copy link
Collaborator

It looks good now ("This branch has no conflicts with the base branch when rebasing").
I'll merge once the CI build is done.

@TommyMurphyTM1234
Copy link
Collaborator Author

It looks good now ("This branch has no conflicts with the base branch when rebasing"). I'll merge once the CI build is done.

Thanks @cmuellner. 👍

@TommyMurphyTM1234
Copy link
Collaborator Author

Oops - mistake in original commit addressed here:

@cmuellner cmuellner merged commit 8b1a750 into riscv-collab:master Oct 11, 2024
26 checks passed
@TommyMurphyTM1234
Copy link
Collaborator Author

Thanks a lot @cmuellner. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants