Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add requirement python3-tomli #1614

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

karaketir16
Copy link
Contributor

python3-tomli required for build-sim SIM=qemu in Ubuntu 22.04, I did not try other operating systems.

@karaketir16
Copy link
Contributor Author

fix #1615

@TommyMurphyTM1234
Copy link
Collaborator

python3-tomli required for build-sim SIM=qemu in Ubuntu 22.04, I did not try other operating systems.

Why wouldn't this have triggered a problem here?

when this package isn't part of the prerequisites installation script?

  • apt install -y autoconf automake autotools-dev curl python3 python3-pip libmpc-dev libmpfr-dev \
    libgmp-dev gawk build-essential bison flex texinfo gperf libtool \
    patchutils bc zlib1g-dev libexpat-dev git ninja-build cmake libglib2.0-dev expect \
    device-tree-compiler python3-pyelftools libslirp-dev

@karaketir16
Copy link
Contributor Author

If I understand correctly, you are using a GitHub Ubuntu Image, that has pre-installed tools.

https://github.com/actions/runner-images/blob/ubuntu22/20241015.1/images/ubuntu/Ubuntu2204-Readme.md

But, I cannot found tomli in the list.

@karaketir16
Copy link
Contributor Author

The error is added with this patch.

https://patchwork.kernel.org/project/qemu-devel/patch/[email protected]/

@karaketir16
Copy link
Contributor Author

I have checked.

https://github.com/karaketir16/test-workflows/actions/runs/11853849709/job/33034785384#step:4:1

GitHub Runner Ubuntu 22.04 image has tomli

@mickflemm
Copy link
Contributor

I ran this a few days back on a fresh ubuntu 22.04 container from the LXD repo and I didn't have to install tomli, the build script of QEMU uses a python venv and installs needed packages itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants