Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install qemu TCG plugins to ${INSTALL_DIR}/lib/qemu/plugins #1684

Closed

Conversation

wangpc-pp
Copy link
Collaborator

So that we can use some plugins to do profiling. For example, use
libinsn.so to count dynamic instructions.

So that we can use some plugins to do profiling. For example, use
`libinsn.so` to count dynamic instructions.
Copy link
Collaborator

@cmuellner cmuellner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might be sufficient to use --enable-plugins and/or $(MAKE) -C $(notdir $@) plugins. Then we don't need to do manual copying.

@wangpc-pp
Copy link
Collaborator Author

I think it might be sufficient to use --enable-plugins and/or $(MAKE) -C $(notdir $@) plugins. Then we don't need to do manual copying.

I don't know if I did something wrong or it just doesn't install plugins. I have tried this method before but I can't find these plugins in qemu installation dir.

@cmuellner
Copy link
Collaborator

cmuellner commented Mar 3, 2025

I think it might be sufficient to use --enable-plugins and/or $(MAKE) -C $(notdir $@) plugins. Then we don't need to do manual copying.

I don't know if I did something wrong or it just doesn't install plugins. I have tried this method before but I can't find these plugins in qemu installation dir.

I've sent a patch to the qemu list to include the plugins when installing:
https://lists.nongnu.org/archive/html/qemu-devel/2025-03/msg00236.html

@wangpc-pp
Copy link
Collaborator Author

I think it might be sufficient to use --enable-plugins and/or $(MAKE) -C $(notdir $@) plugins. Then we don't need to do manual copying.

I don't know if I did something wrong or it just doesn't install plugins. I have tried this method before but I can't find these plugins in qemu installation dir.

I've sent a patch to the qemu list to include the plugins when installing.

Then we don't need this PR anymore if that is merged. Thanks! :-)

@wangpc-pp wangpc-pp closed this Mar 3, 2025
@wangpc-pp wangpc-pp deleted the master-install-qemu-plugins branch March 3, 2025 11:12
@cmuellner
Copy link
Collaborator

Since you closed this PR:
Having the patch in QEMU is the preferred solution.
However, if QEMU does not accept the patch, then I am fine with this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants