-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix image location. #46
Conversation
Signed-off-by: Jiewen Yao <[email protected]>
The logo image comes from the docs-resources submodule and should be referenced from the document header with: :imagesdir: ../docs-resources/images Note that if you'r building the PDF locally, you have to init the sub-modules directory to pull in the code. |
OK. Updated patch according. |
The following is my suggestion for the document header:
It prevents |
Yes, I have updated the patch according to this feedback. |
iopmp.adoc
Outdated
:imagesdir: images | ||
:title-logo-image: image:risc-v_logo.svg[pdfwidth=3.25in,align=center] | ||
:imagesdir: . | ||
:title-logo-image: ./docs-resources/images/image:risc-v_logo.svg[pdfwidth=3.25in,align=center] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line should be
:title-logo-image: image:./docs-resources/images/risc-v_logo.svg[pdfwidth=3.25in,align=center]
This line currently still outputs invalid image location during building PDF. (https://github.com/riscv-non-isa/iopmp-spec/actions/runs/13667321046/job/38211030383#step:4:12)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Updated. I hope it is correct this time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great. I suppose the PR can be merged. @paul-andes
Signed-off-by: Jiewen Yao <[email protected]>
The image location is invalid in original document.