Skip to content

Commit

Permalink
Merge pull request #28 from ved-rivos/editorial_updates
Browse files Browse the repository at this point in the history
formating fixes
  • Loading branch information
ved-rivos authored Apr 12, 2024
2 parents 059fef3 + 9fda4c6 commit 54b4f6c
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 14 deletions.
6 changes: 3 additions & 3 deletions qos_bandwidth.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -254,9 +254,9 @@ establish an accurate counter value for the monitored event.
The counter provides the number of bytes transferred by requests matching the
`EVT_ID` as they go past the monitoring point. A bandwidth value may be
determined by reading the byte count value at two instances of time `T1` and
`T2` (see <<eq-2>>). If the value of the counter at time `T1` was `B1`, and at
time `T2` is `B2`, then the bandwidth can be calculated as follows. The
frequency of the time source is represented by latexmath:[T_{freq}].
`T2`. If the value of the counter at time `T1` was `B1`, and at time `T2` is
`B2`, then the bandwidth can be calculated using <<eq-3>>. The frequency of the
time source is represented by latexmath:[T_{freq}].

[latexmath#eq-3,reftext="equation ({counter:eqs})"]
++++
Expand Down
11 changes: 2 additions & 9 deletions qos_identifiers.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -34,19 +34,12 @@ etc.). Two modes of operation are supported by CBQRI. In the direct mode, the
`MCID` carried with the request is directly used by the controller to identify
the counter and is the effective `MCID`. In the RCID-prefixed mode, the
controller identifies the counter for monitoring using an effective `MCID`
computed as:

[latexmath#eq-1,reftext="equation ({counter:eqs})"]
++++
\begin{equation}
Effective-MCID = (RCID << P) | (MCID \& ((1 << P) - 1))
\end{equation}
++++
computed as: latexmath:[Effective-MCID = (RCID \ll P) \mid (MCID \, \text{&} \, ((1 \ll P) - 1))].

Legal values of `P` range from 0 to 12 and are enumerated in the capability
register of the controller. Software should use the effective `MCID` as the
`MCID` operand to the controller for operations on the monitoring counters.

==== RISC-V hart initiated requests (Ssqosid)

The Ssqosid extension cite:[SSQOSID] introduces a read/write S/HS-mode register
Expand Down
4 changes: 2 additions & 2 deletions qos_sw_guidelines.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@ workload nor the incoming workload, then the scheduler may switch to a new
`srmcfg` configuration that is different from that of either of the workloads
for the duration of such execution.

<<<

=== QoS Configurations for Virtual Machines

Usually for virtual machines the resource allocations are configured by the
Expand All @@ -54,8 +56,6 @@ If a use case requires it, a hypervisor may virtualize the QoS capability to a
VM by virtualizing the memory-mapped CBQRI register interface and virtualizing
the virtual-instruction exception on access to `srmcfg` CSR by the Guest OS.

<<<

[NOTE]
====
If the use of directly selecting among a set of `RCID` and/or `MCID` by a VM
Expand Down

0 comments on commit 54b4f6c

Please sign in to comment.