-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RVA_020: Provide additional context for Ssccfg #21
Conversation
0c1f99a
to
5e44e4b
Compare
This was intentional. The Platform specification is written to provide the requirements that the privilege levels less than M can expect. We have not placed any mandates on the M-mode ISA in the Server Platform or the Server SoC specification. I notice we have Smcntrpmf which I think should also be removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The smcdeleg and smcntrpmf should be remove from the list.
@ved-rivos Thank you for taking a look. The reason for adding I just had a look to confirm the content of For my learning - I was wondering what is the rationale for the platform specification targeting privilege levels less than M. Is there a downside to having M mode extensions also in the list? |
The RVA profiles, server SoC specification, and the server platform specification are written to specify requirements as perceived by the S-mode and lower. This is to ensure we can support a single binary OS distribution on compliant platforms. An implementation that claims support Ssccfg should provide that extension as perceived by the S-mode. We are presently not placing mandates on the M-mode ISA - in fact none of these specifications even require the M-mode ISA to be implemented - for instance the machine mode may be an emulator. |
The Server Platform specification are written to specify requirements as seen by S-mode and lower. The rationale is to not requiring explicit implementation of M-mode ISA. The features provided by Smcntrpmf are implied if Ssccfg is implemented. So it is safe to drop the reference as long as Ssccfg is specififed. Considering the above two points, drop the reference to Smcntrpmf. Signed-off-by: Punit Agrawal <[email protected]>
5e44e4b
to
73307ee
Compare
I've pushed an updated patch doing this. |
The privileged specification includes a chapter about "Smcdeleg" Counter Delegation Extension, Version 1.0.0 that includes the description of Smcdeleg and Ssccfg.
For clarity / ease of finding the the details, update the RVA_020 requirement to include a reference to Smcdeleg.
Closes: #19