-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal of the intrinsics for vector crypto #234
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nick-knight
requested changes
Jun 12, 2023
2a9812c
to
93dcd87
Compare
nick-knight
requested changes
Jul 5, 2023
...ated/vector-crypto/intrinsic_funcs/00_zvbb_-_vector_bit-manipulation_used_in_cryptography.md
Outdated
Show resolved
Hide resolved
...ated/vector-crypto/intrinsic_funcs/00_zvbb_-_vector_bit-manipulation_used_in_cryptography.md
Outdated
Show resolved
Hide resolved
...ated/vector-crypto/intrinsic_funcs/00_zvbb_-_vector_bit-manipulation_used_in_cryptography.md
Outdated
Show resolved
Hide resolved
topperc
reviewed
Jul 5, 2023
4vtomat
reviewed
Jul 12, 2023
4vtomat
reviewed
Jul 12, 2023
4vtomat
reviewed
Jul 12, 2023
4vtomat
reviewed
Jul 12, 2023
4vtomat
reviewed
Jul 12, 2023
4vtomat
reviewed
Jul 12, 2023
4vtomat
reviewed
Jul 12, 2023
4vtomat
reviewed
Jul 12, 2023
4vtomat
reviewed
Jul 12, 2023
4vtomat
reviewed
Jul 12, 2023
4vtomat
reviewed
Jul 12, 2023
4vtomat
reviewed
Jul 12, 2023
auto-generated/vector-crypto/policy_funcs/llvm-api-tests/vclmul.c
Outdated
Show resolved
Hide resolved
4vtomat
reviewed
Jul 12, 2023
auto-generated/vector-crypto/policy_funcs/llvm-api-tests/vclmul.c
Outdated
Show resolved
Hide resolved
4vtomat
reviewed
Jul 12, 2023
auto-generated/vector-crypto/policy_funcs/llvm-api-tests/vclmul.c
Outdated
Show resolved
Hide resolved
4vtomat
reviewed
Jul 12, 2023
auto-generated/vector-crypto/policy_funcs/llvm-api-tests/vclmul.c
Outdated
Show resolved
Hide resolved
4vtomat
reviewed
Jul 12, 2023
4vtomat
reviewed
Jul 12, 2023
4vtomat
reviewed
Jul 12, 2023
} | ||
|
||
vuint32mf2_t test_vsm4r_vs_u32mf2(vuint32mf2_t vd, vuint32mf2_t vs2, size_t vl) { | ||
return __riscv_vsm4r_vs_u32mf2(vd, vs2, vl); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think vs2
of .vs
type of this instruction should have lmul1
type.
4vtomat
reviewed
Jul 12, 2023
auto-generated/vector-crypto/intrinsic_funcs/01_zvbc_-_vector_carryless_multiplication.md
Outdated
Show resolved
Hide resolved
auto-generated/vector-crypto/intrinsic_funcs/04_zvkned_-_nist_suite:_vector_aes_block_cipher.md
Outdated
Show resolved
Hide resolved
auto-generated/vector-crypto/intrinsic_funcs/05_zvkned_-_nist_suite:_vector_aes_block_cipher.md
Outdated
Show resolved
Hide resolved
93dcd87
to
766b9f7
Compare
Address comments from Craig, Nick, Brandon, and Nicholas. Thank you guys for the review. Changes:
|
Signed-off-by: eop Chen <[email protected]>
'vs' instructions will take the first element group from `vs2`, while `vd` can be other settings of register group. This commit adds extra variants for users to choose whatever suits their need. Signed-off-by: eop Chen <[email protected]>
…ake git-commit-autogen-doc)
…git-commit-autogen-test)
…s regarding zvl extensions Signed-off-by: eop Chen <[email protected]>
…tion Signed-off-by: eop Chen <[email protected]>
…git-commit-autogen-test)
- Add operand mnemonics for overloaded intrinsics of vaesef/vsaesem/vaesdf/vaesdm - Add vs2 operand for vaeskf2 - Fix vs2 data type for vwsll
…ake git-commit-autogen-doc)
…git-commit-autogen-test)
…esef/vsaesem/vaesdf/vaesdm Signed-off-by: eop Chen <[email protected]>
…ake git-commit-autogen-doc)
…git-commit-autogen-test)
Signed-off-by: eop Chen <[email protected]>
…git-commit-autogen-test)
…bit-manipulation_used_in_cryptography.md Co-authored-by: Nicolas Brunie <[email protected]> Signed-off-by: Kito Cheng <[email protected]>
4290ece
to
3374d74
Compare
Rebase |
4vtomat
added a commit
to 4vtomat/llvm-project
that referenced
this pull request
Aug 28, 2024
The C intrinsic spec is ratified: riscv-non-isa/rvv-intrinsic-doc#234.
4vtomat
added a commit
to llvm/llvm-project
that referenced
this pull request
Aug 29, 2024
…06359) The C intrinsic spec is ratified: riscv-non-isa/rvv-intrinsic-doc#234.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update (2023/11/11)
The vector crypto extension is now has a released v1.0.0 [0]. This PR creates intrinsics that exposes interfaces to the vector crypto instructions.
Regarding the data type used in the intrinsics added, this proposal does not model the concept of "element grouping (EGS/EGW)" and reuses the existing data types of the RVV intrinsics (e.g.
vuint32m1_t
,vuint64m2_t
).The LLVM implementation of the intrinsics is the following: (to be updated to latest v20230531)
[0] https://github.com/riscv/riscv-crypto/releases/tag/v1.0.0