-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First big batch of instructions skeletons #138
Conversation
Signed-off-by: Afonso Oliveira <[email protected]>
Signed-off-by: Afonso Oliveira <[email protected]>
Signed-off-by: Afonso Oliveira <[email protected]>
Signed-off-by: Afonso Oliveira <[email protected]>
Signed-off-by: Afonso Oliveira <[email protected]>
Signed-off-by: Afonso Oliveira <[email protected]>
Signed-off-by: Afonso Oliveira <[email protected]>
Signed-off-by: Afonso Oliveira <[email protected]>
Signed-off-by: Afonso Oliveira <[email protected]>
Signed-off-by: Afonso Oliveira <[email protected]>
Regression test passed locally, I might have added some folder by mistake, I'll try to fix it asap. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, it seems that every skeleton sets data_independent_timing to true, correct? Could you change that to false? I think that will make it easier to get the correct list in later.
Signed-off-by: Afonso Oliveira <[email protected]>
@dhower-qc This is related to fence.i not having the parameter "variables", there was none on yours, but I guess now it's breaking the validation. Shall I add an empty "variables" field?
|
Signed-off-by: Afonso Oliveira <[email protected]>
a1cc3a7
to
6d525ab
Compare
Everything should now be ready. |
Signed-off-by: Afonso Oliveira <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!!
This PR has the instructions skeletons of the following extension:
Q and D are also almost ready but I am modifying registers naming.