Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First big batch of instructions skeletons #138

Merged
merged 14 commits into from
Oct 20, 2024

Conversation

AFOliveira
Copy link
Collaborator

This PR has the instructions skeletons of the following extension:

  • Zicfiss
  • Zifencei
  • H
  • Zabha
  • Zacas
  • Zalasr
  • Zawrs
  • Zfbfmin
  • Zicond

Q and D are also almost ready but I am modifying registers naming.

Signed-off-by: Afonso Oliveira <[email protected]>
Signed-off-by: Afonso Oliveira <[email protected]>
Signed-off-by: Afonso Oliveira <[email protected]>
Signed-off-by: Afonso Oliveira <[email protected]>
Signed-off-by: Afonso Oliveira <[email protected]>
Signed-off-by: Afonso Oliveira <[email protected]>
Signed-off-by: Afonso Oliveira <[email protected]>
Signed-off-by: Afonso Oliveira <[email protected]>
Signed-off-by: Afonso Oliveira <[email protected]>
Signed-off-by: Afonso Oliveira <[email protected]>
@AFOliveira AFOliveira requested a review from dhower-qc as a code owner October 18, 2024 15:51
@AFOliveira
Copy link
Collaborator Author

Regression test passed locally, I might have added some folder by mistake, I'll try to fix it asap.

Copy link
Collaborator

@dhower-qc dhower-qc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, it seems that every skeleton sets data_independent_timing to true, correct? Could you change that to false? I think that will make it easier to get the correct list in later.

arch/inst/H/hinval.gvma.yaml Outdated Show resolved Hide resolved
arch/inst/Zifencei/fence.i.yaml Outdated Show resolved Hide resolved
@AFOliveira
Copy link
Collaborator Author

@dhower-qc This is related to fence.i not having the parameter "variables", there was none on yours, but I guess now it's breaking the validation. Shall I add an empty "variables" field?

Parsing IDL code for RV64...done
Type checking IDL code for _64...

Instructions: |================================================================|

CSRs: |========================================================================|

Functions: |===================================================================|
/home/runner/work/riscv-unified-db/riscv-unified-db/lib/validate.rb:239:in `block in validate_instruction_encoding': undefined method `count' for nil:NilClass (NoMethodError)

        vars_match = variables.count { |variable| ary_from_location(variable["location"]).include?(i) }
                              ^^^^^^
	from /home/runner/work/riscv-unified-db/riscv-unified-db/lib/validate.rb:236:in `times'

@AFOliveira AFOliveira force-pushed the AFOliveira/AllInstructionsSkeletons branch from a1cc3a7 to 6d525ab Compare October 18, 2024 21:56
@AFOliveira
Copy link
Collaborator Author

Everything should now be ready.

Copy link
Collaborator

@dhower-qc dhower-qc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@dhower-qc dhower-qc merged commit 7e0ba67 into main Oct 20, 2024
1 check passed
@dhower-qc dhower-qc deleted the AFOliveira/AllInstructionsSkeletons branch October 20, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants