Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arch_def generation for CRD #140

Merged
merged 8 commits into from
Oct 21, 2024
Merged

Add arch_def generation for CRD #140

merged 8 commits into from
Oct 21, 2024

Conversation

dhower-qc
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@james-ball-qualcomm james-ball-qualcomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the typo I found, I'm wondering how you tested it.

As a second question, is there anything I need to change in the CRD Ruby or Template to accommodate the change?

lib/arch_def.rb Outdated Show resolved Hide resolved
@dhower-qc dhower-qc marked this pull request as ready for review October 18, 2024 20:34
@dhower-qc
Copy link
Collaborator Author

now it has been tested, and the PR is active

@dhower-qc dhower-qc merged commit 55134c0 into main Oct 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MC-1 PDF has mstatus as 64 bits and fields (like SIE) that shouldn't be present
2 participants