176 missing description for mip csr #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Fixed mie to be defined by Sm not I extension. Description for mip and mie is now shared mimicing ISA manual.
dhower-qc
previously requested changes
Nov 14, 2024
Signed-off-by: james-ball-qualcomm <[email protected]>
…th from mie to mip description to accomodate new schema change.
|
I've merged in the changes made to the schema into this branch so it can be merged into main if you are happy with it. |
|
As we discussed on the side, we need to get |
|
I think this is ready to be merged into main after you review it. |
james-ball-qualcomm
dismissed
dhower-qc’s stale review
Make the requested change
dhower-qc
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created $copy to copy string values like $ref. Added unit-level test. Fixed mie to be defined by Sm not I extension. Description for mip and mie is now shared mimicing ISA manual.
Fixes #176