-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LLVM verification #356
Draft
AFOliveira
wants to merge
7
commits into
main
Choose a base branch
from
AFOliveira/LLVM
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
LLVM verification #356
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
d9b50b2
Add simple Docker environment variable
AFOliveira 1a14ba8
Fix errors due to incorrect parsing of VM
AFOliveira afc753e
First Refactor to pytest
AFOliveira 29ec737
Allow 16 bit instructions for C extension
AFOliveira 6a81b5d
Revert bad parsing
AFOliveira a4b5c39
Allow only one value
AFOliveira 66ef487
Use AsmString instead of name
AFOliveira File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use the
!instanceof
metadata to only search through things with an encoding, I pointed this out in the comment about the initial approach. This will save you iterating through aliases (and other data like isel patterns)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I can see
!instanceof
follows this structure, but I'm finding it hard to understand how to use it for the parsing purposes, can you please further explain?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, let's assume you parsed the whole json object, into a python variable called
json
.json["!instanceof"]
is a map, from tablegen classes, to a list of definition names that are instances of that class (or its sub-classes). These definition names appear in the top-level json.You would use code like the following:
This saves you having to look at all the tablegen data that is not an instruction (so an alias or a pattern or CSR or something).
Note you'll still have to look at
isPseudo
andisCodeGenOnly
and potentially exclude items where one or both of those is true.