CHERI PTE fault overhaul #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like a commit from an earlier PR sneaked into this PR? |
|
The top commit ("CHERI PTE fault overhaul") looks OK by me, and I agree it's just clarifying the existing behaviors. |
yeah thanks - I was worried then when this goes to review they'd be confused by what a CHERI PTE fault actually is |
arichardson
reviewed
Feb 12, 2025
tariqkurd-repo
force-pushed
the
pte_fault_overhaul
branch
from
1fdd768 to
5081224
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the previous definitions really weren't very clear
no spec changes, just clarifying the doc
for some reason the changes from #530 are showing here, no idea why