Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RVV segment load/store instructions #271

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

wangpc-pp
Copy link
Contributor

This is needed by golang (and maybe other languages) porting.

We set nf field explicitly.

@wangpc-pp
Copy link
Contributor Author

cc @4a6f656c

@sequencer
Copy link
Contributor

See

"nf", 31, 29

@wangpc-pp
Copy link
Contributor Author

See

"nf", 31, 29

I don't get it, what do you mean here? We should remove it from this table?

@sequencer
Copy link
Contributor

nf is already encoded in arg_lut, explicit using them in the table is strange, and may break the backward compatibility.

@wangpc-pp
Copy link
Contributor Author

nf is already encoded in arg_lut, explicit using them in the table is strange, and may break the backward compatibility.

We can just remove it. Currenly, we don't generate memonics for segment load/store in both Golang/Rust. Yes, it is OK for Chisel and other HDL targets, but it is necessary for software porting.

@sequencer
Copy link
Contributor

I see, adding seg load store instruction explicitly look good to me. If this is merged, we can follow it.

@wangpc-pp
Copy link
Contributor Author

Ping.

1 similar comment
@wangpc-pp
Copy link
Contributor Author

Ping.

This is needed by golang (and maybe other languages) porting.

We set `nf` field explicitly.
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.40%. Comparing base (383cbca) to head (e4db348).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #271      +/-   ##
==========================================
- Coverage   96.53%   94.40%   -2.14%     
==========================================
  Files          10       10              
  Lines         750      750              
==========================================
- Hits          724      708      -16     
- Misses         26       42      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants