Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(frontend): extract code for parsing table def sql into single stmt #19948

Merged
merged 3 commits into from
Dec 30, 2024

Conversation

BugenZhao
Copy link
Member

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

As title.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

Signed-off-by: Bugen Zhao <[email protected]>
/// Returns the parsed SQL definition when the table was created.
///
/// Returns error if it's invalid.
pub fn create_stmt(&self) -> Result<ast::Statement> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about

Suggested change
pub fn create_stmt(&self) -> Result<ast::Statement> {
pub fn create_sql_ast(&self) -> Result<ast::Statement> {

Signed-off-by: Bugen Zhao <[email protected]>
@BugenZhao BugenZhao enabled auto-merge December 30, 2024 03:33
Signed-off-by: Bugen Zhao <[email protected]>
@BugenZhao BugenZhao added this pull request to the merge queue Dec 30, 2024
auto-merge was automatically disabled December 30, 2024 05:41

Pull Request is not mergeable

auto-merge was automatically disabled December 30, 2024 05:41

Pull Request is not mergeable

auto-merge was automatically disabled December 30, 2024 05:42

Pull Request is not mergeable

auto-merge was automatically disabled December 30, 2024 05:42

Pull Request is not mergeable

auto-merge was automatically disabled December 30, 2024 05:42

Pull Request is not mergeable

auto-merge was automatically disabled December 30, 2024 05:42

Pull Request is not mergeable

auto-merge was automatically disabled December 30, 2024 05:42

Pull Request is not mergeable

auto-merge was automatically disabled December 30, 2024 05:43

Pull Request is not mergeable

auto-merge was automatically disabled December 30, 2024 05:43

Pull Request is not mergeable

Merged via the queue into main with commit 2659bf2 Dec 30, 2024
10 checks passed
@BugenZhao BugenZhao deleted the bz/zealous-wombat branch December 30, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants