Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(connector): improve mysql error message #20135

Merged
merged 1 commit into from
Jan 13, 2025
Merged

fix(connector): improve mysql error message #20135

merged 1 commit into from
Jan 13, 2025

Conversation

kwannoel
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@kwannoel Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@kwannoel kwannoel mentioned this pull request Jan 13, 2025
Merged
8 tasks
@kwannoel kwannoel changed the title improve error message fix(connector): improve mysql error message Jan 13, 2025
@kwannoel kwannoel marked this pull request as ready for review January 13, 2025 11:02
@github-actions github-actions bot added the type/fix Bug fix label Jan 13, 2025
@kwannoel kwannoel requested review from BugenZhao and StrikeW January 13, 2025 11:03
@kwannoel kwannoel added this pull request to the merge queue Jan 13, 2025
Merged via the queue into main with commit 20a68b0 Jan 13, 2025
41 of 43 checks passed
@kwannoel kwannoel deleted the 01-13-improve_error_message branch January 13, 2025 13:07
github-actions bot pushed a commit that referenced this pull request Jan 13, 2025
@kwannoel
fix(connector): improve mysql error message (#20135)
4961988
This was referenced Jan 13, 2025
Merged
Open
github-merge-queue bot pushed a commit that referenced this pull request Jan 14, 2025
@github-actions @kwannoel
fix(connector): improve mysql error message (#20135) (#20143)
5d6e0f2 
Co-authored-by: Noel Kwan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BugenZhao BugenZhao BugenZhao approved these changes

@StrikeW StrikeW Awaiting requested review from StrikeW

Assignees
No one assigned
Labels
need-cherry-pick-release-2.1 need-cherry-pick-release-2.2 type/fix Bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kwannoel @BugenZhao