fix: telemetry init channel unsuccessful leads to panic #20160
+14
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
following #20000
bug report in Slack: https://risingwave-community.slack.com/archives/C03BW71523T/p1736509111698569
and provided log file: https://risingwave-community.slack.com/files/U05J27L4A9L/F088411E1D1/rw.logs
see from the log that a line is
rw-standalone-compute risingwave_common::telemetry::report: Telemetry failed to set event reporting tx, event reporting will be disabled
.I am not sure why it cannot allocate a channel and has not been reproduced yet. Proposing adding a check before handling events related info
update: shared static var leads to the issue in standalone mode. the details described in the comments.
Checklist
Documentation
Release note