Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: telemetry init channel unsuccessful leads to panic #20160

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

tabVersion
Copy link
Contributor

@tabVersion tabVersion commented Jan 14, 2025

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

following #20000

bug report in Slack: https://risingwave-community.slack.com/archives/C03BW71523T/p1736509111698569
and provided log file: https://risingwave-community.slack.com/files/U05J27L4A9L/F088411E1D1/rw.logs

see from the log that a line is rw-standalone-compute risingwave_common::telemetry::report: Telemetry failed to set event reporting tx, event reporting will be disabled.

I am not sure why it cannot allocate a channel and has not been reproduced yet. Proposing adding a check before handling events related info

update: shared static var leads to the issue in standalone mode. the details described in the comments.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

tabversion added 2 commits January 14, 2025 22:04
@github-actions github-actions bot added the type/fix Bug fix label Jan 14, 2025
@hzxa21 hzxa21 self-requested a review January 15, 2025 03:45
Copy link
Collaborator

@hzxa21 hzxa21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

src/common/src/telemetry/report.rs Outdated Show resolved Hide resolved
src/common/src/telemetry/report.rs Outdated Show resolved Hide resolved
@tabVersion tabVersion enabled auto-merge January 15, 2025 13:06
@tabVersion tabVersion added this pull request to the merge queue Jan 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants