Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(telemetry): not send report if cluster is in test env #20180

Merged
merged 9 commits into from
Jan 22, 2025
Merged

fix(telemetry): not send report if cluster is in test env #20180

merged 9 commits into from
Jan 22, 2025
+39 −22

Conversation

tabVersion
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

per request from @neverchanje , suspect many UNSPECIFIED deployment type are leaked from test env.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

neverchanje
neverchanje approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@neverchanje neverchanje left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can consider marking the cluster with ReportBase_IsTest = true. The approach in this PR can work too.
You may choose whichever approach that requires least efforts.

@tabVersion
Copy link
Contributor Author

You can consider marking the cluster with ReportBase_IsTest = true. The approach in this PR can work too. You may choose whichever approach that requires least efforts.

Yes, it also make sense. I will check how I can broadcast the status from meta to other nodes.

@tabVersion tabVersion marked this pull request as draft January 16, 2025 07:02
tabVersion
tabVersion commented Jan 21, 2025
View reviewed changes
src/meta/src/telemetry.rs
@@ -156,6 +156,10 @@ impl MetaTelemetryInfoFetcher {
#[async_trait::async_trait]
impl TelemetryInfoFetcher for MetaTelemetryInfoFetcher {
async fn fetch_telemetry_info(&self) -> TelemetryResult<Option<String>> {
// the err here means building cluster on test env, so we don't need to report telemetry
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other nodes get TrackingID from this func, via meta rpc interface. If we do not offer a TrackingID here, the report on other nodes will be disabled.

@tabVersion tabVersion marked this pull request as ready for review January 21, 2025 08:17
@gru-agent Gru Agent
Copy link

gru-agent bot commented Jan 21, 2025

This pull request has been modified. If you want me to regenerate unit test for any of the files related, please find the file in "Files Changed" tab and add a comment @gru-agent. (The github "Comment on this file" feature is in the upper right corner of each file in "Files Changed" tab.)

@tabVersion
Copy link
Contributor Author

tested locally with

  set_env ENABLE_TELEMETRY "true"
  set_env RW_TELEMETRY_TYPE "test"
image

The telemetry service is disabled.

@tabVersion tabVersion added this pull request to the merge queue Jan 22, 2025
Merged via the queue into main with commit e0e0e78 Jan 22, 2025
36 of 37 checks passed
@tabVersion tabVersion deleted the tab/check-deployment branch January 22, 2025 06:18
github-actions bot pushed a commit that referenced this pull request Jan 22, 2025
@tabVersion
fix(telemetry): not send report if cluster is in test env (#20180)
931a7cf 
Co-authored-by: tabversion <[email protected]>
@github-actions github-actions bot mentioned this pull request Jan 22, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jan 23, 2025
@github-actions @tabVersion
fix(telemetry): not send report if cluster is in test env (#20180) (#…
a39fe1d 
…20256)

Signed-off-by: tabversion <[email protected]>
Co-authored-by: Bohan Zhang <[email protected]>
Co-authored-by: tabversion <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neverchanje neverchanje neverchanje approved these changes

@fuyufjh fuyufjh Awaiting requested review from fuyufjh

@alicelyy alicelyy Awaiting requested review from alicelyy

Assignees
No one assigned
Labels
ci/run-e2e-single-node-tests ci/run-e2e-test-other-backends need-cherry-pick-release-2.2 type/fix Bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tabVersion @neverchanje