-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(iceberg): support iceberg connection #20189
Conversation
'DROP TABLE IF EXISTS demo_db.test_connection_table', | ||
'DROP SCHEMA IF EXISTS demo_db', | ||
] | ||
iceberg_connection |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There appears to be a stray iceberg_connection
line at the end of this TOML file that should be removed. This line isn't valid TOML syntax and could interfere with proper file parsing.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi, there. 📝 Telemetry Reminder:
|
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
database.name
andtable.name
.Example:
Checklist
Documentation
Release note