Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(meta): fix incorrect displayed worker type #20193

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Conversation

zwang28
Copy link
Contributor

@zwang28 zwang28 commented Jan 17, 2025

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

WorkerType::Meta will be converted to 4 which should be 5.
The impact of this bug is, the worker_type of meta node will be displayed as Compactor when select * from rw_worker_nodes.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@zwang28 zwang28 added this pull request to the merge queue Jan 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 17, 2025
@zwang28 zwang28 added this pull request to the merge queue Jan 20, 2025
Merged via the queue into main with commit 6f53371 Jan 20, 2025
39 of 40 checks passed
@zwang28 zwang28 deleted the wangzheng/fix_display branch January 20, 2025 05:34
github-merge-queue bot pushed a commit that referenced this pull request Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants