-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(frontend): allow specifying (partial) schema when creating table with derived schema #20203
base: main
Are you sure you want to change the base?
Conversation
1c7ca3f
to
0e3215d
Compare
… with derived schema
Signed-off-by: Bugen Zhao <[email protected]>
…y for adding columns Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
43f3ea8
to
c6c301c
Compare
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Hi, there. 📝 Telemetry Reminder:
|
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
This pull request has been modified. If you want me to regenerate unit test for any of the files related, please find the file in "Files Changed" tab and add a comment |
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
I think this is more like a potential documentation improvement. 🥵 |
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
This is a follow-up of #20131:
This PR removes the
Reject
strategy and adds aFollowChecked
instead, which means that we will follow the columns specified in SQL with schema check against the external system.As a result, users can now specify the (maybe partial) schema when creating a table with a derived schema (i.e., using a schema registry). Consequently,
REFRESH SCHEMA
and[ADD | DROP] COLUMN
can be called on any table, regardless of whether its schema was initially derived or manually specified.Also affect
CREATE SOURCE
. ForALTER SOURCE
, as its code path now differs fromALTER TABLE
, the behavior keeps unchanged. Will check it in future PRs.Close #12199.
Checklist
Documentation
Release note