Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(iceberg): remove unnecessary JSON serde #20212

Merged
merged 1 commit into from
Jan 20, 2025
Merged

refactor(iceberg): remove unnecessary JSON serde #20212

merged 1 commit into from
Jan 20, 2025

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Jan 20, 2025

Signed-off-by: xxchan [email protected]

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@xxchan xxchan force-pushed the xxchan/iceberg-json branch from a2f4a18 to d2f6525 Compare January 20, 2025 05:07
@gru-agent Gru Agent
Copy link

gru-agent bot commented Jan 20, 2025

This pull request has been modified. If you want me to regenerate unit test for any of the files related, please find the file in "Files Changed" tab and add a comment @gru-agent. (The github "Comment on this file" feature is in the upper right corner of each file in "Files Changed" tab.)

@xxchan xxchan force-pushed the xxchan/iceberg-json branch from d2f6525 to e2b5d8c Compare January 20, 2025 05:10
@xxchan xxchan requested review from chenzl25, Li0k and xxhZs January 20, 2025 05:10
@xxchan xxchan enabled auto-merge January 20, 2025 05:11
chenzl25
chenzl25 approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@chenzl25 chenzl25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Li0k
Li0k approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@Li0k Li0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xxchan xxchan added this pull request to the merge queue Jan 20, 2025
Merged via the queue into main with commit a19acf5 Jan 20, 2025
39 of 40 checks passed
@xxchan xxchan deleted the xxchan/iceberg-json branch January 20, 2025 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenzl25 chenzl25 chenzl25 approved these changes

@Li0k Li0k Li0k approved these changes

@xxhZs xxhZs Awaiting requested review from xxhZs

Assignees
No one assigned
Labels
ci/run-e2e-iceberg-engine-tests ci/run-e2e-iceberg-sink-v2-tests type/refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xxchan @chenzl25 @Li0k