Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make dashboard prometheus queries work with cloud data sources #20242

Merged
merged 3 commits into from
Jan 21, 2025

Conversation

arkbriar
Copy link
Contributor

@arkbriar arkbriar commented Jan 21, 2025

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

  1. Update the Prometheus queries used in the meta dashboard service to accommodate the cloud data sources where
  • the job label doesn't have the same meaning
  • a new label component is provided to express the node roles
  1. Add standalone in the filter in order to get data for standalone deployments. However, the meta dashboard (web) itself needs a change to accommodate with the model itself.

The query works as long as job and component are not provided simultaneously and identically.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

Signed-off-by: arkbriar <[email protected]>
Copy link

gru-agent bot commented Jan 21, 2025

This pull request has been modified. If you want me to regenerate unit test for any of the files related, please find the file in "Files Changed" tab and add a comment @gru-agent. (The github "Comment on this file" feature is in the upper right corner of each file in "Files Changed" tab.)

@arkbriar arkbriar added this pull request to the merge queue Jan 21, 2025
Merged via the queue into main with commit 2c378ac Jan 21, 2025
31 of 32 checks passed
@arkbriar arkbriar deleted the shunjie/fix-promql-for-meta-dashboard branch January 21, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants