fix: finish source backfill immediately for scan.startup.mode=latest #20285
+42
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow up of #18342. For "there's no history data to backfill at all", we just checked `low_watermark == high_watermark`, but `start_offset == high_watermark-1` is also a case. We may meet this case when `scan.startup.mode=latest`: #20083 (comment) Signed-off-by: xxchan <[email protected]>
xxchan
added
need-cherry-pick-release-2.1
need-cherry-pick-release-2.2
and removed
type/fix
xxchan
commented
Jan 24, 2025
Comment on lines
+393
to
+394
| statement ok | ||
| create materialized view mv_latest as select * from s_latest; |
There was a problem hiding this comment.
Before this PR, this DDL will be blocked.
Signed-off-by: xxchan <[email protected]>
|
This pull request has been modified. If you want me to regenerate unit test for any of the files related, please find the file in "Files Changed" tab and add a comment |
kwannoel
approved these changes
Jan 24, 2025
tabVersion
approved these changes
Jan 24, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jan 24, 2025
…20285) Signed-off-by: xxchan <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Jan 24, 2025
…20285) Signed-off-by: xxchan <[email protected]>
8 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 24, 2025
…20285) (#20289) Signed-off-by: xxchan <[email protected]> Co-authored-by: xxchan <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 25, 2025
…20285) (#20290) Signed-off-by: xxchan <[email protected]> Co-authored-by: xxchan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up of #18342.
For "there's no history data to backfill at all", we just checked
low_watermark == high_watermark, butstart_offset == high_watermark-1is also a case.We may meet this case when
scan.startup.mode=latest: #20083 (comment)Signed-off-by: xxchan [email protected]
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Checklist
Documentation
Release note