fix: list one page in fs source executor #20292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 24, 2025 14:29
|
This pull request has been modified. If you want me to regenerate unit test for any of the files related, please find the file in "Files Changed" tab and add a comment |
kwannoel
approved these changes
Jan 24, 2025
wcy-fdu
approved these changes
Jan 24, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jan 24, 2025
Co-authored-by: tabversion <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Jan 24, 2025
Co-authored-by: tabversion <[email protected]>
This was referenced Jan 24, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 24, 2025
Co-authored-by: Bohan Zhang <[email protected]> Co-authored-by: tabversion <[email protected]>
xxchan
reviewed
Jan 27, 2025
Comment on lines
101
to
110
| async fn list_splits(&mut self) -> crate::error::ConnectorResult<Vec<Self::Split>> { | ||
| let mut objects = Vec::new(); | ||
| loop { | ||
| let (files, has_finished) = self.get_next_page::<FsSplit>().await?; | ||
| objects.extend(files); | ||
| if has_finished { | ||
| break; | ||
| } | ||
| } | ||
| Ok(objects) | ||
| // fetch one page as validation, no need to get all pages | ||
| let (_, _) = self.get_next_page::<FsSplit>().await?; | ||
|
|
||
| Ok(vec![FsSplit { | ||
| name: "empty_split".to_owned(), | ||
| offset: 0, | ||
| size: 0, | ||
| }]) | ||
| } |
There was a problem hiding this comment.
Is this correct for legacy s3 enumerator? IIUC its splits need to be enumerated in meta 🤔
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 27, 2025
Signed-off-by: tabversion <[email protected]> Co-authored-by: Bohan Zhang <[email protected]> Co-authored-by: tabversion <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
as title, we don't need to list all files in fs source enuerator
Checklist
Documentation
Release note