Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(risedev): Add resource-group #20329

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions risedev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,29 @@ profile:
- use: compute-node
- use: frontend

# Start 4 CNs with resource groups rg1, rg2, and default
multiple-resource-groups:
steps:
- use: minio
- use: meta-node
- use: compactor
- use: compute-node
port: 5687
exporter-port: 1222
enable-tiered-cache: true
resource-group: "rg1"
- use: compute-node
port: 5688
exporter-port: 1223
resource-group: "rg2"
enable-tiered-cache: true
- use: compute-node
port: 5689
exporter-port: 1224
enable-tiered-cache: true
- use: frontend


ci-time-travel:
config-path: src/config/ci-time-travel.toml
steps:
Expand Down Expand Up @@ -1175,6 +1198,9 @@ template:

role: both

# Resource group for scheduling, default value is "default"
resource-group: "default"

meta-node:
# Meta-node advertise address
address: "127.0.0.1"
Expand Down
1 change: 1 addition & 0 deletions src/risedevtool/src/service_config.rs
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ pub struct ComputeNodeConfig {
pub provide_aws_s3: Option<Vec<AwsS3Config>>,
pub provide_tempo: Option<Vec<TempoConfig>>,
pub user_managed: bool,
pub resource_group: String,

pub total_memory_bytes: usize,
pub parallelism: usize,
Expand Down
4 changes: 3 additions & 1 deletion src/risedevtool/src/task/compute_node_service.rs
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,9 @@ impl ComputeNodeService {
.arg("--total-memory-bytes")
.arg(config.total_memory_bytes.to_string())
.arg("--role")
.arg(&config.role);
.arg(&config.role)
.arg("--resource-group")
.arg(&config.resource_group);

let provide_meta_node = config.provide_meta_node.as_ref().unwrap();
add_meta_node(provide_meta_node, cmd)?;
Expand Down
Loading