Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): wait committed epoch when update vnode bitmap #20492

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wenym1
Copy link
Contributor

@wenym1 wenym1 commented Feb 13, 2025

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Part of #18312

In this PR, on update_vnode_bitmap of LocalStateStore, we will explicitly wait for the previous epoch to be committed, so that after update_vnode_bitmap returns, the local state store is ready to be read, and doesn't depend on correctly calling try_wait_epoch outside of it.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@wenym1 wenym1 changed the base branch from main to yiming/log-store-state-post-yield-update-vnode February 13, 2025 12:02
Copy link

gru-agent bot commented Feb 13, 2025

❌ Rebase test pr failed: Error: Pull request #20492 is not created by gru-agent[bot]

Copy link
Contributor Author

wenym1 commented Feb 13, 2025

Base automatically changed from yiming/log-store-state-post-yield-update-vnode to main February 14, 2025 04:59
Copy link

gru-agent bot commented Feb 14, 2025

❌ Rebase test pr failed: Error: Pull request #20492 is not created by gru-agent[bot]

@wenym1 wenym1 force-pushed the yiming/wait-epoch-when-update-vnode-bitmap branch from ee10be7 to 079b77c Compare February 14, 2025 07:00
@wenym1 wenym1 requested review from hzxa21, Li0k and BugenZhao February 17, 2025 08:19
@wenym1 wenym1 force-pushed the yiming/wait-epoch-when-update-vnode-bitmap branch from e8a7949 to 832be59 Compare February 20, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant