Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(test): change embedded udf tests to parallel, fix some failing tests #20531

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

chore(test): change embedded udf tests to parallel, fix some failing tests #20531

wants to merge 4 commits into from
+246 −266

Conversation

stdrc
Copy link
Member

@stdrc stdrc commented Feb 18, 2025 •
edited
Loading

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

  • Re-include some UDF e2e tests, fix failing tests accordingly
  • Move embedded UDF tests to parallel, leaving only external UDF tests in serial

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@stdrc stdrc changed the title change embedded udf tests to parallel, fix somem failing tests chore(test): change embedded udf tests to parallel, fix somem failing tests Feb 18, 2025
@stdrc Graphite App
Copy link
Member Author

stdrc commented Feb 18, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@stdrc stdrc mentioned this pull request Feb 18, 2025
Merged
8 tasks
@stdrc stdrc changed the title chore(test): change embedded udf tests to parallel, fix somem failing tests chore(test): change embedded udf tests to parallel, fix some failing tests Feb 18, 2025
@stdrc stdrc requested review from kwannoel and xxchan February 18, 2025 14:33
@stdrc stdrc marked this pull request as ready for review February 18, 2025 14:33
stdrc
stdrc commented Feb 18, 2025
View reviewed changes
e2e_test/udf/rust_udf.slt Outdated
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Split into udf/embedded/rust

stdrc
stdrc commented Feb 18, 2025
View reviewed changes
e2e_test/udf/retry_python.slt Outdated
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not run before, duplicate with always_retry_python.slt.

stdrc
stdrc commented Feb 18, 2025
View reviewed changes
e2e_test/udf/general/create_and_drop.slt Outdated
$$;

statement ok
create sink s as select add(a, b) as c from t with (connector = 'blackhole');
Copy link
Member Author

@stdrc stdrc Feb 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will panic if put it after dropping the above MVs. See #20527

@stdrc stdrc force-pushed the rc/parallelize-some-e2e-2 branch 2 times, most recently from 78e009c to 7dd2cb0 Compare February 18, 2025 15:52
xxchan
xxchan approved these changes Feb 19, 2025
View reviewed changes
Copy link
Member

@xxchan xxchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice

kwannoel
kwannoel approved these changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@kwannoel kwannoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very very nice

Base automatically changed from rc/parallelize-some-e2e to main February 19, 2025 07:23
@buildkite buildkite bot requested a review from a team as a code owner February 19, 2025 07:23
@buildkite buildkite bot requested a review from MrCroxx February 19, 2025 07:23
@stdrc stdrc force-pushed the rc/parallelize-some-e2e-2 branch from 520ca72 to d632339 Compare February 19, 2025 07:27
@stdrc
update arrow-udf-python
4515afb 
Signed-off-by: Richard Chien <[email protected]>
@stdrc stdrc mentioned this pull request Feb 21, 2025
Merged
8 tasks
@stdrc stdrc changed the base branch from main to graphite-base/20531 February 21, 2025 09:34
@stdrc stdrc force-pushed the rc/parallelize-some-e2e-2 branch from d632339 to c1bdba7 Compare February 21, 2025 09:34
@stdrc stdrc changed the base branch from graphite-base/20531 to rc/upgrade-arrow-udf-python-to-fix-py-udf February 21, 2025 09:34
Base automatically changed from rc/upgrade-arrow-udf-python-to-fix-py-udf to main February 21, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xxchan xxchan xxchan approved these changes

@kwannoel kwannoel kwannoel approved these changes

@MrCroxx MrCroxx Awaiting requested review from MrCroxx MrCroxx is a code owner automatically assigned from risingwavelabs/cargo-lock

Assignees
No one assigned
Labels
type/chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stdrc @xxchan @kwannoel