Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(meta): deprecate dispatcher table and compose dispatcher by fragment relation #20541

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wenym1
Copy link
Contributor

@wenym1 wenym1 commented Feb 19, 2025

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

With FragmentRelation table introduced, we don't have to persist the dispatcher information. Therefore, in this PR, we will deprecate the dispatcher table. In all places that used the dispatcher table, we will change to use the FragmentRelation table.

Previously, the dispatcher is used in either resolving the logical connection between fragments, or loading the existing physical dispatchers. For resolving the logical connection between fragments, we can use the FragmentRelation directly. For loading existing physical dispatchers, we can actually recompose the physical dispatchers by combining information in FragmentRelation table and the vnode distribution of upstream and downstream actors.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@wenym1 wenym1 force-pushed the yiming/deprecate-persisted-actor-dispatcher branch 3 times, most recently from 6643525 to 878575c Compare February 19, 2025 15:02
Base automatically changed from yiming/deprecate-persisted-actor-upstreams to main February 20, 2025 08:40
@wenym1 wenym1 force-pushed the yiming/deprecate-persisted-actor-dispatcher branch 2 times, most recently from f524b43 to cfd4e73 Compare February 20, 2025 08:54
@wenym1 wenym1 force-pushed the yiming/deprecate-persisted-actor-dispatcher branch from cfd4e73 to 48b2492 Compare February 20, 2025 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant