Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(storage): remove unnecessary fields from ReadOptions #20545

Open
wants to merge 1 commit into
base: yiming/state-store-get-trait
Choose a base branch
from

Conversation

wenym1
Copy link
Contributor

@wenym1 wenym1 commented Feb 20, 2025

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

Copy link
Contributor Author

wenym1 commented Feb 20, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@wenym1 wenym1 force-pushed the yiming/state-store-get-trait branch from ffdd8ab to 1b82f79 Compare February 20, 2025 09:15
@wenym1 wenym1 force-pushed the yiming/remove-read-options-table-id branch from 6554f62 to c8eaebe Compare February 20, 2025 09:16
Copy link
Contributor Author

@wenym1 wenym1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR has two preliminary PRs. Are you interested in also reviewing the two refactor PRs #20172 and #20175? @ClSlaid

@wenym1 wenym1 force-pushed the yiming/state-store-get-trait branch from 1b82f79 to 016af19 Compare February 21, 2025 07:57
@wenym1 wenym1 force-pushed the yiming/remove-read-options-table-id branch from c8eaebe to c2e7025 Compare February 21, 2025 07:58
@wenym1 wenym1 force-pushed the yiming/remove-read-options-table-id branch from c2e7025 to 029bb8b Compare February 21, 2025 13:24
@wenym1 wenym1 changed the title refactor(storage): remove table_id from ReadOptions refactor(storage): remove unnecessary fields from ReadOptions Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants