Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wsl/setup-git.ts): fix uncorrectly escaped gh auth commands #848

Merged
merged 1 commit into from
Nov 14, 2024
Merged

fix(wsl/setup-git.ts): fix uncorrectly escaped gh auth commands #848

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion wsl/setup-git.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ const ensureGitHubTokenScopes = async (): Promise<() => Promise<void>> => {
// bun shell doesn't support reading from stdout and stderr while running a command
// ref: https://github.com/oven-sh/bun/issues/14693
const process = spawn(
["gh", "auth", ...$.escape(subcommand).split(" ")],
["gh", "auth", ...subcommand.split(" ")],
// default is "inherit" which just logs to the console
// ref: https://bun.sh/docs/api/spawn#output-streams
{ stderr: "pipe" },
Expand Down