chore(main): release 0.21.0 #920
Conversation
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe pull request introduces a new version entry for Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
dreulavelle
force-pushed
the
release-please--branches--main
branch
2 times, most recently
from
e853e06 to
d939443
Compare
dreulavelle
force-pushed
the
release-please--branches--main
branch
2 times, most recently
from
1774043 to
9b5297b
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
CHANGELOG.md (1)
4-5: Remove unnecessary empty lines.There are two consecutive empty lines between the version header and the bug fixes section. One empty line is sufficient for readability.
## [0.20.2](https://github.com/rivenmedia/riven/compare/v0.20.1...v0.20.2) (2024-12-06) - - ### Bug Fixes
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
CHANGELOG.md(1 hunks)pyproject.toml(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- pyproject.toml
🔇 Additional comments (1)
CHANGELOG.md (1)
3-14: LGTM! Version entry follows semantic versioning and changelog conventions.
The changes are well-documented with:
- Appropriate version number for bug fixes (patch version)
- Clear descriptions of changes
- Proper linking to commits and issues
dreulavelle
force-pushed
the
release-please--branches--main
branch
from
9b5297b to
37ab8b7
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
CHANGELOG.md (2)
6-8: Consider adding more context about the symlinker retry change.While the feature is well documented with proper references, it would be helpful to include the rationale for adding a 6th retry attempt to the symlinker. This context would help users understand the impact and importance of this change.
11-19: Consider improving consistency and clarity of bug fix entries.Some suggestions for improvement:
- Add issue references for entries that don't have them (lines 13-15)
- Make commit messages more descriptive:
- "api manual scraping fixes. wip" could be more specific about what was fixed
- "manual scraping updated for downloader rework" could explain the key changes
Consider applying this format to the entries:
-* api manual scraping fixes. wip ([7fb50f8](https://github.com/rivenmedia/riven/commit/7fb50f856d2395d2cbdc977a35e0a5ae152eecc0)) +* fix: improve API manual scraping by [specific changes] ([#issue](https://github.com/rivenmedia/riven/issues/issue)) ([7fb50f8](https://github.com/rivenmedia/riven/commit/7fb50f856d2395d2cbdc977a35e0a5ae152eecc0))
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
CHANGELOG.md(1 hunks)pyproject.toml(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- pyproject.toml
🔇 Additional comments (1)
CHANGELOG.md (1)
3-5: LGTM! Version header follows the standard format.
The version header is properly formatted with the correct GitHub compare link and date.
dreulavelle
force-pushed
the
release-please--branches--main
branch
from
37ab8b7 to
964a7f1
Compare
dreulavelle
force-pushed
the
release-please--branches--main
branch
from
964a7f1 to
1b4c6a2
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
CHANGELOG.md (1)
6-9: Consider enhancing the breaking changes section.While the Torbox removal is properly documented, it would be helpful to add a brief explanation of the impact on users and any necessary migration steps.
### ⚠ BREAKING CHANGES -* Torbox Removal ([#971](https://github.com/rivenmedia/riven/issues/971)) +* Torbox functionality has been completely removed ([#971](https://github.com/rivenmedia/riven/issues/971)). Users relying on Torbox will need to switch to alternative providers.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
CHANGELOG.md(1 hunks)pyproject.toml(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- pyproject.toml
🔇 Additional comments (1)
CHANGELOG.md (1)
3-25: LGTM! The changelog for version 1.0.0 is well-structured and complete.The changelog properly documents all changes mentioned in the PR objectives, including:
- Breaking change: Torbox removal
- New feature: 6th retry attempt for symlinker
- Multiple bug fixes with proper references to issues and commit hashes
dreulavelle
force-pushed
the
release-please--branches--main
branch
from
1b4c6a2 to
3ca5a72
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
CHANGELOG.md (2)
6-9: Consider adding migration guidance for the breaking change.While the Torbox removal is properly documented and linked to issue #971, it would be helpful to include:
- Impact on existing configurations
- Steps for users to migrate from Torbox
- Alternative solutions or recommendations
10-13: Consider enhancing the feature description.While the addition of a 6th retry attempt is documented, it would be beneficial to include:
- The purpose of adding another retry attempt
- Expected impact on reliability
- Any configuration changes needed
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
CHANGELOG.md(1 hunks)pyproject.toml(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- pyproject.toml
🔇 Additional comments (2)
CHANGELOG.md (2)
3-5: LGTM! Version header is well-formatted.The version header follows the conventional changelog format and includes the correct comparison link and release date.
15-25: LGTM! Bug fixes are well-documented.The bug fixes section is comprehensive and follows good practices:
- Clear descriptions for each fix
- Proper commit hash references
- Issue links where applicable
dreulavelle
force-pushed
the
release-please--branches--main
branch
from
3ca5a72 to
5500ba3
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
CHANGELOG.md (1)
15-25: Bug fixes section needs better organization.While the bug fixes are well-documented with commit references, consider grouping related fixes together for better readability. For example:
- API-related fixes (scrape endpoint, ListrrAPI)
- Mediafusion-related fixes (alldebrid, catalog configuration)
- File processing fixes (sample handling, instantavail)
Consider reorganizing the bug fixes section like this:
### Bug Fixes +#### API Improvements * add strong typed response to scrape api endpoint ([44f047e](https://github.com/rivenmedia/riven/commit/44f047e7e00c58628fa0669f1630b80f8bbe936e)) * update ListrrAPI validate method to use correct path ([#906](https://github.com/rivenmedia/riven/issues/906)) ([7659a37](https://github.com/rivenmedia/riven/commit/7659a37d30704b46107b6441e7a40f386ec82101)) + +#### Mediafusion Updates * add alldebrid as option in mediafusion ([42829a2](https://github.com/rivenmedia/riven/commit/42829a2e245169443187ca581bf2dce190f1c7c9)) * remove catalog configuration from Mediafusion settings and scraper ([#919](https://github.com/rivenmedia/riven/issues/919)) ([fc7ed05](https://github.com/rivenmedia/riven/commit/fc7ed053dbd9c39df869c61a147bfbf8890a6503)) + +#### File Processing * fixed alldebrid instantavail file processing ([#916](https://github.com/rivenmedia/riven/issues/916)) ([d2a6b5b](https://github.com/rivenmedia/riven/commit/d2a6b5bbf0e2c83e3f6f4899e8a367af72d05ae7)) * updated sample handling for allowed video files ([8a5e849](https://github.com/rivenmedia/riven/commit/8a5e849aca371c28c418270bdbb863770389f2b7)) + +#### Other Changes * api manual scraping fixes. wip ([7fb50f8](https://github.com/rivenmedia/riven/commit/7fb50f856d2395d2cbdc977a35e0a5ae152eecc0)) * manual scraping updated for downloader rework ([346b352](https://github.com/rivenmedia/riven/commit/346b352c3c6dfcf857b04d65a396ce06e1d70263)) * Torbox Removal ([#971](https://github.com/rivenmedia/riven/issues/971)) ([5d49499](https://github.com/rivenmedia/riven/commit/5d49499ddfc2582945048f1444a3d3445bb58cef))
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
CHANGELOG.md(1 hunks)pyproject.toml(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- pyproject.toml
🔇 Additional comments (3)
CHANGELOG.md (3)
3-5: Version header follows semantic versioning.The version header is well-formatted with:
- Correct semantic version (1.0.0)
- GitHub compare link
- Release date
6-9: Breaking change is properly highlighted.The breaking change (Torbox removal) is correctly marked with the "⚠ BREAKING CHANGES" section and references the relevant issue (#971).
10-13: Feature addition is well documented.The feature section clearly describes the addition of a 6th retry attempt to the symlinker with proper issue (#926) and commit reference.
| * fixed alldebrid instantavail file processing ([#916](https://github.com/rivenmedia/riven/issues/916)) ([d2a6b5b](https://github.com/rivenmedia/riven/commit/d2a6b5bbf0e2c83e3f6f4899e8a367af72d05ae7)) | ||
| * manual scraping updated for downloader rework ([346b352](https://github.com/rivenmedia/riven/commit/346b352c3c6dfcf857b04d65a396ce06e1d70263)) | ||
| * remove catalog configuration from Mediafusion settings and scraper ([#919](https://github.com/rivenmedia/riven/issues/919)) ([fc7ed05](https://github.com/rivenmedia/riven/commit/fc7ed053dbd9c39df869c61a147bfbf8890a6503)) | ||
| * Torbox Removal ([#971](https://github.com/rivenmedia/riven/issues/971)) ([5d49499](https://github.com/rivenmedia/riven/commit/5d49499ddfc2582945048f1444a3d3445bb58cef)) |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Duplicate entry for Torbox removal.
The Torbox removal is mentioned both in the breaking changes section and bug fixes section. This is redundant and might confuse users.
Remove the duplicate entry from the bug fixes section since it's already covered in the breaking changes section:
-* Torbox Removal ([#971](https://github.com/rivenmedia/riven/issues/971)) ([5d49499](https://github.com/rivenmedia/riven/commit/5d49499ddfc2582945048f1444a3d3445bb58cef))
dreulavelle
force-pushed
the
release-please--branches--main
branch
from
5500ba3 to
1ae0655
Compare
dreulavelle
force-pushed
the
release-please--branches--main
branch
from
1ae0655 to
9492d8e
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
CHANGELOG.md (1)
17-24: Maintain consistent capitalization in commit messages.Some commit messages start with capital letters while others don't. For consistency, consider standardizing the capitalization:
-* add alldebrid as option in mediafusion ([42829a2]) -* add strong typed response to scrape api endpoint ([44f047e]) -* api manual scraping fixes. wip ([7fb50f8]) -* fixed alldebrid instantavail file processing ([#916]) ([d2a6b5b]) -* manual scraping updated for downloader rework ([346b352]) -* remove catalog configuration from Mediafusion settings and scraper ([#919]) ([fc7ed05]) -* Torbox Removal ([#971]) ([5d49499]) -* update ListrrAPI validate method to use correct path ([#906]) ([7659a37]) +* Add alldebrid as option in mediafusion ([42829a2]) +* Add strong typed response to scrape api endpoint ([44f047e]) +* API manual scraping fixes. wip ([7fb50f8]) +* Fixed alldebrid instantavail file processing ([#916]) ([d2a6b5b]) +* Manual scraping updated for downloader rework ([346b352]) +* Remove catalog configuration from Mediafusion settings and scraper ([#919]) ([fc7ed05]) +* Update ListrrAPI validate method to use correct path ([#906]) ([7659a37])
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
CHANGELOG.md(1 hunks)pyproject.toml(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- pyproject.toml
🔇 Additional comments (1)
CHANGELOG.md (1)
23-23: Remove duplicate Torbox entry.The Torbox removal is already documented in the breaking changes section.
dreulavelle
force-pushed
the
release-please--branches--main
branch
from
9492d8e to
f516abc
Compare
dreulavelle
force-pushed
the
release-please--branches--main
branch
4 times, most recently
from
83505ee to
0dd1799
Compare
dreulavelle
force-pushed
the
release-please--branches--main
branch
from
0dd1799 to
cbc76f0
Compare
🤖 I have created a release beep boop
0.21.0 (2025-02-11)
⚠ BREAKING CHANGES
Features
Bug Fixes
Miscellaneous Chores
This PR was generated with Release Please. See documentation.