FIXUP: scripts

utils/run-tests.sh

@@ -3,7 +3,7 @@
 SCRIPTDIR="$(readlink -f "$(dirname "$0")")"
 TOPDIR="$(readlink -f "${SCRIPTDIR}/..")"
 
-test_env="/tmp/ansible-freeipa-tests"
+# test_env="/tmp/ansible-freeipa-tests"
 
 # shellcheck source=utils/shfun
 . "${SCRIPTDIR}/shfun"
@@ -138,7 +138,7 @@ log info "Installing dependencies from 'requirements-tests.txt'"
 pip install --upgrade -r "${TOPDIR}/requirements-tests.txt"
 
 # shellcheck disable=SC2119
-[ -z "SKIP_ANSIBLE" ] && install_ansible
+[ -z "${SKIP_ANSIBLE}" ] && install_ansible
 
 # Ansible configuration
 export ANSIBLE_ROLES_PATH="${TOPDIR}/roles"

utils/setup_test_container.sh

@@ -71,7 +71,9 @@ scenario="${1}"
 shift
 
 make_inventory "${scenario}" "${engine:-podman}" "${ansible_interpreter:-"/usr/bin/python3"}"
+# shellcheck disable=SC2154
 log info "Inventory path: [${inventory}]"
+# shellcheck disable=SC2154
 log debug "$(cat "${inventory}")"
 prepare_container "${scenario}" "${IMAGE_TAG}"
 start_container "${scenario}"

utils/shfun

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/bin/bash -eu
 # This file is meant to be source'd by bash scripts
 
 # shellcheck disable=SC2034