Skip to content

Commit

Permalink
idoverideuser: Use module.params_get_type
Browse files Browse the repository at this point in the history
Use the commom parameter type handling method for parameters that accept
a value or an empty string.
  • Loading branch information
rjeffman committed Sep 18, 2023
1 parent a453ab9 commit 8d7c2ba
Showing 1 changed file with 2 additions and 16 deletions.
18 changes: 2 additions & 16 deletions plugins/modules/ipaidoverrideuser.py
Original file line number Diff line number Diff line change
Expand Up @@ -439,9 +439,9 @@ def main():
# present
description = ansible_module.params_get("description")
name = ansible_module.params_get("name")
uid = ansible_module.params_get("uid")
uid = ansible_module.params_get_type("uid", int)
gecos = ansible_module.params_get("gecos")
gidnumber = ansible_module.params_get("gidnumber")
gidnumber = ansible_module.params_get_type("gidnumber", int)
homedir = ansible_module.params_get("homedir")
shell = ansible_module.params_get("shell")
sshpubkey = ansible_module.params_get("sshpubkey")
Expand Down Expand Up @@ -479,20 +479,6 @@ def main():

ansible_module.params_fail_used_invalid(invalid, state, action)

# Ensure parameter values are valid and have proper type.
def int_or_empty_param(value, param):
if value is not None and value != "":
try:
value = int(value)
except ValueError:
ansible_module.fail_json(
msg="Invalid value '%s' for argument '%s'" % (value, param)
)
return value

uid = int_or_empty_param(uid, "uid")
gidnumber = int_or_empty_param(gidnumber, "gidnumber")

if certificate is not None:
certificate = [cert.strip() for cert in certificate]

Expand Down

0 comments on commit 8d7c2ba

Please sign in to comment.