Skip to content

Commit

Permalink
Disable rollForward for SDK in global.json (#170)
Browse files Browse the repository at this point in the history
Update .NET SDK to the latest released version and disable
`rollForward`.

Updates to the .NET SDK feature band can introduce new / updated
analyzers (for instance, 8.0.400 adds
[IDE0320](dotnet/roslyn#73012)). As a result,
updating the feature band isn't "safe" to do from a build
reproducibility perspective. It will also conflict with #166.

That means the roll forward options available to us are:

- `patch`
- `latestPatch`
- `disable`

However, GitHub Actions don't support these options (tracked by
actions/setup-dotnet#448). Thus, the only
`rollForward` strategy that currently does the same thing locally and in
CI is `disabled`.

Once 448 is fixed, we can / should probably switch to `latestPatch`
(tracked by #171).

This 'gotcha' is also added to the SquiggleCop documentation
[here](https://github.com/MattKotsenas/SquiggleCop?tab=readme-ov-file#common-sources-of-baseline-mismatches).
  • Loading branch information
MattKotsenas authored Aug 1, 2024
1 parent a883a67 commit 8ae2592
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions global.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"sdk": {
"version": "8.0.101",
"rollForward": "latestFeature"
"version": "8.0.303",
"rollForward": "disable"
},
"msbuild-sdks": {
"DotNet.ReproducibleBuilds.Isolated": "1.2.4"
Expand Down

0 comments on commit 8ae2592

Please sign in to comment.