Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External Redirect Fix and Configure Case Sensitivity #13

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

zparrott
Copy link

The following pull request is to fix a bug I found in the external redirect. I also added the ability to make the redirect case insensitive through the plugin's configuration file.

…o the scope of the referenced object which caused comparing of unintended records.
…irects through the plugin's configuration file.
@rkingon
Copy link
Owner

rkingon commented Nov 18, 2015

thanks, i'll check it out.

not sure if I want to have a global setting for insensitive, this is something that should be done at a redirect level. To date, I have just been prefixing the regex string with (?i) which makes the match case insensitive. My approach would be a checkmark that just adds the \i flag to the regex match.

any specific reason you chose a config file vs using plugin settings?

auralon added a commit to auralon/Craft-Plugin--Redirect-Manager that referenced this pull request Nov 20, 2017
When running a console command, I stumbled upon this error...

    PHP Error[8]: Undefined index: SERVER_NAME
        in file /var/www/foobar/craft/app/framework/web/CHttpRequest.php at line 352
    #0 /var/www/foobar/craft/app/etc/console/ConsoleApp.php(265): Craft\ConsoleApp->handleError()
    rkingon#1 /var/www/foobar/craft/app/framework/web/CHttpRequest.php(352): Craft\ConsoleApp->handleError()
    rkingon#2 /var/www/foobar/craft/app/services/ConfigService.php(420): Craft\HttpRequestService->getHostInfo()
    rkingon#3 /var/www/foobar/craft/app/etc/web/UrlManager.php(80): Craft\ConfigService->usePathInfo()
    rkingon#4 /var/www/foobar/craft/app/framework/base/CModule.php(394): Craft\UrlManager->init()
    rkingon#5 /var/www/foobar/craft/app/etc/console/ConsoleApp.php(220): Craft\ConsoleApp->getComponent()
    rkingon#6 /var/www/foobar/craft/app/framework/base/CModule.php(103): Craft\ConsoleApp->getComponent()
    rkingon#7 /var/www/foobar/craft/app/services/HttpRequestService.php(1163): Craft\ConsoleApp->__get()
    rkingon#8 /var/www/foobar/craft/plugins/redirectmanager/RedirectManagerPlugin.php(43): Craft\HttpRequestService->getQueryStringWithoutPath()
    rkingon#9 /var/www/foobar/craft/app/services/PluginsService.php(150): Craft\RedirectManagerPlugin->init()
    rkingon#10 /var/www/foobar/craft/app/etc/console/ConsoleApp.php(86): Craft\PluginsService->loadPlugins()
    rkingon#11 /var/www/foobar/craft/app/framework/base/CApplication.php(170): Craft\ConsoleApp->init()
    rkingon#12 /var/www/foobar/craft/app/framework/YiiBase.php(121): Craft\ConsoleApp->__construct()
    rkingon#13 /var/www/foobar/craft/app/etc/console/yiic.php(86): createApplication()
    rkingon#14 /var/www/foobar/utils/yiic_frontend.php(24): require()

This patch fixes the issue.
rkingon pushed a commit that referenced this pull request Nov 20, 2017
When running a console command, I stumbled upon this error...

    PHP Error[8]: Undefined index: SERVER_NAME
        in file /var/www/foobar/craft/app/framework/web/CHttpRequest.php at line 352
    #0 /var/www/foobar/craft/app/etc/console/ConsoleApp.php(265): Craft\ConsoleApp->handleError()
    #1 /var/www/foobar/craft/app/framework/web/CHttpRequest.php(352): Craft\ConsoleApp->handleError()
    #2 /var/www/foobar/craft/app/services/ConfigService.php(420): Craft\HttpRequestService->getHostInfo()
    #3 /var/www/foobar/craft/app/etc/web/UrlManager.php(80): Craft\ConfigService->usePathInfo()
    #4 /var/www/foobar/craft/app/framework/base/CModule.php(394): Craft\UrlManager->init()
    #5 /var/www/foobar/craft/app/etc/console/ConsoleApp.php(220): Craft\ConsoleApp->getComponent()
    #6 /var/www/foobar/craft/app/framework/base/CModule.php(103): Craft\ConsoleApp->getComponent()
    #7 /var/www/foobar/craft/app/services/HttpRequestService.php(1163): Craft\ConsoleApp->__get()
    #8 /var/www/foobar/craft/plugins/redirectmanager/RedirectManagerPlugin.php(43): Craft\HttpRequestService->getQueryStringWithoutPath()
    #9 /var/www/foobar/craft/app/services/PluginsService.php(150): Craft\RedirectManagerPlugin->init()
    #10 /var/www/foobar/craft/app/etc/console/ConsoleApp.php(86): Craft\PluginsService->loadPlugins()
    #11 /var/www/foobar/craft/app/framework/base/CApplication.php(170): Craft\ConsoleApp->init()
    #12 /var/www/foobar/craft/app/framework/YiiBase.php(121): Craft\ConsoleApp->__construct()
    #13 /var/www/foobar/craft/app/etc/console/yiic.php(86): createApplication()
    #14 /var/www/foobar/utils/yiic_frontend.php(24): require()

This patch fixes the issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants