Protect StatefulPool from class methods #225
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StatefulPool doesn't support batching over with class methods because it always passes `G` as the first argument to the worker function. If one of the `run_` methods in StatefulPool is called with a class method it can lead to a silent lock-up of the pool, which is very difficult to debug. Note: this bug does not appear unless n_parallel > 1
ryanjulian
force-pushed
the
protect_stateful_pool
branch
from
4b41d10
to
03a0271
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StatefulPool doesn't support batching over with class methods because it
always passes
Gas the first argument to the worker function. If one of therun_methods in StatefulPool is called with a class method it can lead toa silent lock-up of the pool, which is very difficult to debug.
Note: this bug does not appear unless n_parallel > 1