Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

for building wrims #6

Draft
wants to merge 16 commits into
base: wrims-devops
Choose a base branch
from
Draft

for building wrims #6

wants to merge 16 commits into from

Conversation

rma-tom
Copy link
Collaborator

@rma-tom rma-tom commented Jan 4, 2024

No description provided.

Copy link
Member

@adamkorynta adamkorynta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These directories should not get added:
./gradle
./wrims-core/.gradle
./gradle/license-plugin

@rma-tom rma-tom requested a review from adamkorynta January 5, 2024 21:54
@rma-tom rma-tom force-pushed the Feature/wrims-core branch from 4831e17 to 342303c Compare January 5, 2024 22:07
Copy link
Member

@adamkorynta adamkorynta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The deletes from the wrims_v2 directory are missing, I presume that means they weren't moved and instead just copied (which means history was lost).

@rma-tom rma-tom force-pushed the Feature/wrims-core branch from 1eb6a43 to d740ded Compare January 8, 2024 18:30
@rma-tom
Copy link
Collaborator Author

rma-tom commented Jan 8, 2024

Revised per Adam's requests. Histories of java and grammar files are traceable from wrims-core locations. Non- (java or grammar) source files remain in the wrims_v2 folder

@rma-tom rma-tom force-pushed the Feature/wrims-core branch 2 times, most recently from 94276d2 to bc4e45e Compare January 12, 2024 23:20
adamkorynta added a commit that referenced this pull request Jan 15, 2024
update downstream plugins to make sure JDK 8 is used
@rma-tom rma-tom force-pushed the Feature/wrims-core branch from bee9444 to a5a1b30 Compare January 15, 2024 20:59
@rma-tom rma-tom force-pushed the Feature/wrims-core branch from 0617665 to e4dba8f Compare January 19, 2024 23:10
@rma-tom rma-tom force-pushed the Feature/wrims-core branch from e4dba8f to bb350cc Compare January 20, 2024 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants