Make typing hints work with Python 3.9 to 3.11 #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change typing hints to allow static type checkers to work if client code uses Python 3.9 to Python 3.11. Background: > The type statement is new in Python 3.12. For > backwards compatibility, type aliases can also > be created through simple assignment: Link: https://docs.python.org/3/library/typing.html
claui
force-pushed
the
typecheck-compat
branch
from
df09162 to
a1a3977
Compare
|
Turns out that I had to leave one of the However, that unit test is only for Python 3.12 or above anyway, so it shouldn’t have any impact on lower versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes typing hints to allow static type checkers to work if client code uses Python 3.9 to Python 3.11.
Background:
I have tested the change with client code in 3.9, 3.10, 3.11, 3.12, and 3.13, and found that this PR fixes the issues in all affected versions (3.9 through 3.11).
This PR, together with PR #177, fixes issue #176.